238631 – [CMake] Make a WebKit::TestRunnerShared target

Bug 238631 - [CMake] Make a WebKit::TestRunnerShared target

Summary: [CMake] Make a WebKit::TestRunnerShared target

Status:	RESOLVED FIXED

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	CMake (show other bugs)
Version:	WebKit Nightly Build
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Don Olmstead

URL:
Keywords:

Depends on:
Blocks:

Reported:	2022-03-31 13:53 PDT by Don Olmstead
Modified:	2022-12-14 22:08 PST (History)
CC List:	7 users (show)

See Also:

Attachments
Patch (1.67 KB, patch) 2022-03-31 14:07 PDT, Don Olmstead	aperez: review+ ews-feeder: commit-queue-	Details \| Formatted Diff \| Diff
WIP Patch for AppleWin (4.25 KB, patch) 2022-04-01 09:25 PDT, Don Olmstead	ews-feeder: commit-queue-	Details \| Formatted Diff \| Diff
WIP Patch for AppleWin (4.34 KB, patch) 2022-04-01 09:34 PDT, Don Olmstead	ews-feeder: commit-queue-	Details \| Formatted Diff \| Diff
WIP Patch for AppleWin (5.41 KB, patch) 2022-04-01 10:04 PDT, Don Olmstead	ews-feeder: commit-queue-	Details \| Formatted Diff \| Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Don Olmstead 2022-03-31 13:53:05 PDT

Use _FRAMEWORKS to get rid of additional definitions

Comment 1 Don Olmstead 2022-03-31 14:07:11 PDT

Created attachment 456278 [details]
Patch

Comment 2 Don Olmstead 2022-04-01 09:25:01 PDT

Created attachment 456365 [details]
WIP Patch for AppleWin

AppleWin seems to be failing with DumpRenderTree...

Comment 3 Don Olmstead 2022-04-01 09:34:01 PDT

Created attachment 456366 [details]
WIP Patch for AppleWin

Comment 4 Don Olmstead 2022-04-01 10:04:39 PDT

Created attachment 456370 [details]
WIP Patch for AppleWin

Comment 5 Don Olmstead 2022-12-14 18:02:45 PST

Pull request: https://github.com/WebKit/WebKit/pull/7663

Comment 6 EWS 2022-12-14 22:07:59 PST

Committed 257904@main (4e2cc15056fa): <https://commits.webkit.org/257904@main>

Reviewed commits have been landed. Closing PR #7663 and removing active labels.