Bug 238573 - Add a placeholder for some additional Captive Portal mode settings
Summary: Add a placeholder for some additional Captive Portal mode settings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-03-30 13:50 PDT by Brent Fulgham
Modified: 2022-03-31 13:01 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.67 KB, patch)
2022-03-30 13:54 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Patch (1.68 KB, patch)
2022-03-30 14:46 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Patch (1.69 KB, patch)
2022-03-30 15:51 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Patch for landing (1.69 KB, patch)
2022-03-31 10:20 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2022-03-30 13:50:29 PDT 
Add a macro placeholder for some future Captive Portal settings.
Comment 1 Radar WebKit Bug Importer 2022-03-30 13:51:14 PDT 
<rdar://problem/91064718>
Comment 2 Brent Fulgham 2022-03-30 13:54:25 PDT 
Created attachment 456171 [details]
Patch
Comment 3 Wenson Hsieh 2022-03-30 14:17:43 PDT 
Comment on attachment 456171 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456171&action=review

> Source/WebKit/WebProcess/WebPage/WebPage.cpp:4106
> +    CAPTIVE_PORTAL_WEB_PAGE_ADDITIONS();

Could we factor this out into a static helper function instead?
Comment 4 Brent Fulgham 2022-03-30 14:46:40 PDT 
Created attachment 456178 [details]
Patch
Comment 5 Tim Horton 2022-03-30 15:02:40 PDT 
Comment on attachment 456178 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456178&action=review

> Source/WebKit/WebProcess/WebPage/WebPage.cpp:396
> +#import <WebKitAdditions/WebPageAdditions.h>

This should be a .cpp file.
Comment 6 Brent Fulgham 2022-03-30 15:37:26 PDT 
Comment on attachment 456178 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456178&action=review

>> Source/WebKit/WebProcess/WebPage/WebPage.cpp:396
>> +#import <WebKitAdditions/WebPageAdditions.h>
> 
> This should be a .cpp file.

Will fix.
Comment 7 Brent Fulgham 2022-03-30 15:51:48 PDT 
Created attachment 456182 [details]
Patch
Comment 8 Wenson Hsieh 2022-03-31 08:32:11 PDT 
Comment on attachment 456182 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456182&action=review

> Source/WebKit/ChangeLog:12
> +        (WebKit::adjustSettingsForCaptivePortal): Call new placeholder macro.

s/macro/helper function/
Comment 9 Brent Fulgham 2022-03-31 10:20:56 PDT 
Created attachment 456252 [details]
Patch for landing
Comment 10 EWS 2022-03-31 13:01:53 PDT 
Committed r292165 (249072@main): <https://commits.webkit.org/249072@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 456252 [details].