Bug 238572 - [CSS contain] Containment disables the special handling of the HTML body element for overflow viewport propagation [part2]
Summary: [CSS contain] Containment disables the special handling of the HTML body elem...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-03-30 13:22 PDT by zalan
Modified: 2022-03-31 09:49 PDT (History)
11 users (show)

See Also:


Attachments
Patch (4.32 KB, patch)
2022-03-30 13:45 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (4.31 KB, patch)
2022-03-30 14:00 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (4.26 KB, patch)
2022-03-30 19:12 PDT, zalan
ews-feeder: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2022-03-30 13:22:06 PDT
This is when <html> has the containment.
Comment 1 zalan 2022-03-30 13:45:14 PDT
Created attachment 456170 [details]
Patch
Comment 2 Simon Fraser (smfr) 2022-03-30 13:47:05 PDT
Comment on attachment 456170 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456170&action=review

> Source/WebCore/rendering/RenderBox.cpp:514
> +            // (4) No containment is set neither on the body nor on the html document element.

neither/nor -> either/or
Comment 3 zalan 2022-03-30 14:00:36 PDT
Created attachment 456172 [details]
Patch
Comment 4 zalan 2022-03-30 19:12:08 PDT
Created attachment 456194 [details]
Patch
Comment 5 Rob Buis 2022-03-31 06:29:07 PDT
Nice! When I was working on these tests I could not figure out how to fix these three...
Comment 6 zalan 2022-03-31 06:37:23 PDT
(In reply to Rob Buis from comment #5)
> Nice! When I was working on these tests I could not figure out how to fix
> these three...
I am going through this list https://wpt.fyi/results/css/css-contain?label=experimental&label=master&product=chrome&product=firefox&product=safari&aligned&q=label%3Ainterop-2022-contain to see if we can turn some of the red to green.
Comment 7 zalan 2022-03-31 06:40:45 PDT
(In reply to zalan from comment #6)
> (In reply to Rob Buis from comment #5)
> > Nice! When I was working on these tests I could not figure out how to fix
> > these three...
> I am going through this list
> https://wpt.fyi/results/css/css-
> contain?label=experimental&label=master&product=chrome&product=firefox&produc
> t=safari&aligned&q=label%3Ainterop-2022-contain to see if we can turn some
> of the red to green.
Sadly I've already seen some non-actionable/needs more thinking failures e.g. https://trac.webkit.org/changeset/292140/webkit
Comment 8 EWS 2022-03-31 06:57:39 PDT
Committed r292157 (249064@main): <https://commits.webkit.org/249064@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 456194 [details].
Comment 9 Radar WebKit Bug Importer 2022-03-31 06:58:19 PDT
<rdar://problem/91101177>