Bug 238565 - Remove EXPERIMENTAL_FEATURES flag on Cocoa platforms
Summary: Remove EXPERIMENTAL_FEATURES flag on Cocoa platforms
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-03-30 12:06 PDT by Alex Christensen
Modified: 2022-03-31 08:05 PDT (History)
7 users (show)

See Also:

Attachments
Patch (15.12 KB, patch)
2022-03-30 12:10 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (15.16 KB, patch)
2022-03-30 16:31 PDT, Alex Christensen 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2022-03-30 12:06:17 PDT 
Remove EXPERIMENTAL_FEATURES flag
Comment 1 Alex Christensen 2022-03-30 12:10:55 PDT 
Created attachment 456161 [details]
Patch
Comment 2 Don Olmstead 2022-03-30 15:05:15 PDT 
For our CMake ports I'm open to just putting it as ON instead of basing it on the flags. So as an example we have ENABLE_SERVICE_WORKERS as an experimental feature then in this brave new world we'd just make sure that its not enabled by default in the preferences. Is there anything else we should be aware of here when migrating off of ENABLE_EXPERIMENTAL_FEATURES?
Comment 3 Alex Christensen 2022-03-30 16:24:03 PDT 
I guess Source/cmake/WebKitFeatures.cmake and Source/cmake/Options*.cmake use this for something else.  I'm going to leave that as it is and just remove EXPERIMENTAL_FEATURES from the source.
Comment 4 Alex Christensen 2022-03-30 16:31:33 PDT 
Created attachment 456184 [details]
Patch
Comment 5 EWS 2022-03-31 05:46:58 PDT 
Committed r292156 (249063@main): <https://commits.webkit.org/249063@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 456184 [details].
Comment 6 Radar WebKit Bug Importer 2022-03-31 05:47:19 PDT 
<rdar://problem/91099190>