Bug 238550 - Split streaming of AX trees from the class AXLogger.
Summary: Split streaming of AX trees from the class AXLogger.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andres Gonzalez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-03-30 06:51 PDT by Andres Gonzalez
Modified: 2022-03-30 23:03 PDT (History)
11 users (show)

See Also:

Attachments
Patch (11.17 KB, patch)
2022-03-30 07:06 PDT, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
Patch (11.65 KB, patch)
2022-03-30 10:11 PDT, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andres Gonzalez 2022-03-30 06:51:35 PDT 
Split streaming of AX trees from the class AXLogger.
Comment 1 Radar WebKit Bug Importer 2022-03-30 06:51:47 PDT 
<rdar://problem/91041921>
Comment 2 Andres Gonzalez 2022-03-30 07:06:06 PDT 
Created attachment 456117 [details]
Patch
Comment 3 Tyler Wilcock 2022-03-30 08:16:25 PDT 
Comment on attachment 456117 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456117&action=review

> Source/WebCore/accessibility/AXLogger.cpp:568
> +        stream.dumpProperty("roleValue", role);

I know this isn't new with your patch, but I wonder if it would be better to shorten this to role instead of roleValue to make the logs a little less noisy. I get that roleValue is the name of the method in AXCoreObject, but in this case I don't think it's necessary to include the full method name.
Comment 4 Andres Gonzalez 2022-03-30 10:11:44 PDT 
Created attachment 456137 [details]
Patch
Comment 5 Andres Gonzalez 2022-03-30 10:22:12 PDT 
(In reply to Tyler Wilcock from comment #3)
> Comment on attachment 456117 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=456117&action=review
> 
> > Source/WebCore/accessibility/AXLogger.cpp:568
> > +        stream.dumpProperty("roleValue", role);
> 
> I know this isn't new with your patch, but I wonder if it would be better to
> shorten this to role instead of roleValue to make the logs a little less
> noisy. I get that roleValue is the name of the method in AXCoreObject, but
> in this case I don't think it's necessary to include the full method name.

Done.
Comment 6 EWS 2022-03-30 23:03:48 PDT 
Committed r292142 (249049@main): <https://commits.webkit.org/249049@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 456137 [details].