Bug 238521 - Add HashTranslator for ASCIILiteral for faster lookup in HashMaps / HashSets
Summary: Add HashTranslator for ASCIILiteral for faster lookup in HashMaps / HashSets
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-03-29 14:15 PDT by Chris Dumez
Modified: 2022-03-30 10:47 PDT (History)
19 users (show)

See Also:

Attachments
Patch (27.50 KB, patch)
2022-03-29 14:17 PDT, Chris Dumez 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (27.39 KB, patch)
2022-03-29 15:10 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (11.76 KB, patch)
2022-03-30 09:53 PDT, Andres Gonzalez 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2022-03-29 14:15:08 PDT 
Add HashTranslator for ASCIILiteral for faster lookup in HashMaps / HashSets using an ASCIILiteral.
Comment 1 Chris Dumez 2022-03-29 14:17:10 PDT 
Created attachment 456057 [details]
Patch
Comment 2 Chris Dumez 2022-03-29 15:10:15 PDT 
Created attachment 456067 [details]
Patch
Comment 3 Geoffrey Garen 2022-03-29 20:30:13 PDT 
Comment on attachment 456067 [details]
Patch

r=me
Comment 4 EWS 2022-03-30 07:57:52 PDT 
Committed r292106 (249026@main): <https://commits.webkit.org/249026@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 456067 [details].
Comment 5 Radar WebKit Bug Importer 2022-03-30 07:58:17 PDT 
<rdar://problem/91044544>
Comment 6 Andres Gonzalez 2022-03-30 09:53:50 PDT 
Reopening to attach new patch.
Comment 7 Andres Gonzalez 2022-03-30 09:53:53 PDT 
Created attachment 456134 [details]
Patch
Comment 8 Chris Dumez 2022-03-30 09:58:00 PDT 
Reopened by mistake.
Comment 9 Andres Gonzalez 2022-03-30 10:01:03 PDT 
(In reply to Chris Dumez from comment #8)
> Reopened by mistake.

Yes, sorry about that, problem merging the ChangeLog.
Comment 10 Darin Adler 2022-03-30 10:47:54 PDT 
Comment on attachment 456067 [details]
Patch

Seems like we should also eventually add a mechanism so there is a default translator for each type, so we can get rid of most of the explicit <HashTranslatorASCIILiteral>.