Bug 238510 - [LibWPE] Guard libxkbcommon code with WPE_ENABLE_XKB
Summary: [LibWPE] Guard libxkbcommon code with WPE_ENABLE_XKB
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Don Olmstead
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-03-29 09:53 PDT by Don Olmstead
Modified: 2022-03-29 13:27 PDT (History)
7 users (show)

See Also:

Attachments
Patch (5.45 KB, patch)
2022-03-29 10:05 PDT, Don Olmstead 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (5.45 KB, patch)
2022-03-29 10:19 PDT, Don Olmstead 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Don Olmstead 2022-03-29 09:53:40 PDT 
libwpe added an ENABLE flag for support of XKB.
Comment 1 Don Olmstead 2022-03-29 10:05:47 PDT Comment hidden (obsolete)
Comment 2 Don Olmstead 2022-03-29 10:19:06 PDT 
Created attachment 456040 [details]
Patch
Comment 3 Adrian Perez 2022-03-29 12:31:39 PDT 
Comment on attachment 456040 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456040&action=review

> Source/WebKit/UIProcess/Automation/libwpe/WebAutomationSessionLibWPE.cpp:152
>      struct wpe_input_xkb_keymap_entry* entries;

Meh. Too bad we don't have something like GUniqueOutPtr which would
call free() instead of g_free(); it would have been perfect to use
here instead of having the one line of guarded code below 🤷‍♂️️
Comment 4 EWS 2022-03-29 13:26:00 PDT 
Committed r292064 (248998@main): <https://commits.webkit.org/248998@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 456040 [details].
Comment 5 Radar WebKit Bug Importer 2022-03-29 13:27:16 PDT 
<rdar://problem/91001968>