Bug 238504 - Move AuxiliaryProcess::createIPCConnectionPair to IPC::Connection
Summary: Move AuxiliaryProcess::createIPCConnectionPair to IPC::Connection
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kimmo Kinnunen
URL:
Keywords: InRadar
Depends on:
Blocks: 237674
  Show dependency tree / graph
 
Reported: 2022-03-29 07:00 PDT by Kimmo Kinnunen
Modified: 2022-03-30 02:50 PDT (History)
7 users (show)

See Also:

Attachments
Patch (16.18 KB, patch)
2022-03-29 07:06 PDT, Kimmo Kinnunen 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (16.00 KB, patch)
2022-03-29 07:40 PDT, Kimmo Kinnunen 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (16.03 KB, patch)
2022-03-29 09:34 PDT, Kimmo Kinnunen 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kimmo Kinnunen 2022-03-29 07:00:41 PDT 
Move AuxiliaryProcess::createIPCConnectionPair to IPC::Connection
Comment 1 Kimmo Kinnunen 2022-03-29 07:06:23 PDT 
Created attachment 456022 [details]
Patch
Comment 2 Kimmo Kinnunen 2022-03-29 07:40:36 PDT 
Created attachment 456024 [details]
Patch
Comment 3 Kimmo Kinnunen 2022-03-29 07:47:59 PDT 
Comment on attachment 456024 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456024&action=review

> Source/WebKit/WebProcess/Inspector/WebInspectorUI.cpp:105
> +    m_backendConnection = IPC::Connection::createServerConnection(connectionIdentifiers->server, *this);

In this function, before code reuse it 
- created the port
-  set the MACH_MSG_TYPE_MAKE_SEND right
- sent the port right with MACH_MSG_TYPE_MOVE_SEND Attachment disposition

After code reuse:
- created the port
- sent the port right with MACH_MSG_TYPE_MAKE_SEND  Attachment disposition

I think these two should be equivalent?
Comment 4 Kimmo Kinnunen 2022-03-29 09:34:58 PDT 
Created attachment 456032 [details]
Patch
Comment 5 Chris Dumez 2022-03-29 11:25:46 PDT 
Comment on attachment 456032 [details]
Patch

r=me
Comment 6 EWS 2022-03-30 02:49:16 PDT 
Committed r292102 (249022@main): <https://commits.webkit.org/249022@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 456032 [details].
Comment 7 Radar WebKit Bug Importer 2022-03-30 02:50:16 PDT 
<rdar://problem/91034263>