Bug 238487 - Remove -[WKWebsiteDataStore _indexedDBDatabaseDirectory]
Summary: Remove -[WKWebsiteDataStore _indexedDBDatabaseDirectory]
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sihui Liu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-03-28 22:35 PDT by Sihui Liu
Modified: 2022-03-30 16:21 PDT (History)
3 users (show)

See Also:

Attachments
Patch (5.50 KB, patch)
2022-03-28 22:38 PDT, Sihui Liu 		no flags Details | Formatted Diff | Diff
Patch for landing (6.41 KB, patch)
2022-03-30 11:23 PDT, Sihui Liu 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sihui Liu 2022-03-28 22:35:02 PDT 
This is not used in SPI clients; and we have _indexedDBDatabaseDirectory in _WKWebsiteDataStoreConfiguration.
Comment 1 Sihui Liu 2022-03-28 22:38:30 PDT 
Created attachment 455993 [details]
Patch
Comment 2 Alex Christensen 2022-03-30 10:57:18 PDT 
Comment on attachment 455993 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455993&action=review

> Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:-60
> -@property (nonatomic, readonly) NSURL *_indexedDBDatabaseDirectory WK_API_DEPRECATED_WITH_REPLACEMENT("_WKWebsiteDataStoreConfiguration._indexedDBDatabaseDirectory", macos(10.11, 11.0), ios(9.0, 14.0));

Can we also remove from WKWebsiteDataStore.mm?
Comment 3 Sihui Liu 2022-03-30 11:20:27 PDT 
Comment on attachment 455993 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455993&action=review

>> Source/WebKit/UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:-60
>> -@property (nonatomic, readonly) NSURL *_indexedDBDatabaseDirectory WK_API_DEPRECATED_WITH_REPLACEMENT("_WKWebsiteDataStoreConfiguration._indexedDBDatabaseDirectory", macos(10.11, 11.0), ios(9.0, 14.0));
> 
> Can we also remove from WKWebsiteDataStore.mm?

Sure.
Comment 4 Sihui Liu 2022-03-30 11:23:58 PDT 
Created attachment 456155 [details]
Patch for landing
Comment 5 EWS 2022-03-30 16:20:32 PDT 
Committed r292126 (249036@main): <https://commits.webkit.org/249036@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 456155 [details].
Comment 6 Radar WebKit Bug Importer 2022-03-30 16:21:15 PDT 
<rdar://problem/91072951>