Bug 238486 - Regression: WebsiteDataStore fails to read experimental feature values from NSUserDefaults
Summary: Regression: WebsiteDataStore fails to read experimental feature values from N...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sihui Liu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-03-28 21:37 PDT by Sihui Liu
Modified: 2022-03-30 22:10 PDT (History)
5 users (show)

See Also:

Attachments
Patch (7.18 KB, patch)
2022-03-28 21:42 PDT, Sihui Liu 		no flags Details | Formatted Diff | Diff
Patch for landing (7.11 KB, patch)
2022-03-30 15:39 PDT, Sihui Liu 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sihui Liu 2022-03-28 21:37:37 PDT 
...
Comment 1 Sihui Liu 2022-03-28 21:42:49 PDT 
Created attachment 455991 [details]
Patch
Comment 2 Sihui Liu 2022-03-29 14:57:08 PDT 
Ping reviewers
Comment 3 Alex Christensen 2022-03-30 10:59:53 PDT 
Comment on attachment 455991 [details]
Patch

This is responding to the change in Safari, but we should be moving towards using SPI to set these values in WKWebsiteDataStoreConfiguration instead of having WebKit read from defaults.
Comment 4 Sihui Liu 2022-03-30 15:39:50 PDT 
Created attachment 456180 [details]
Patch for landing
Comment 5 EWS 2022-03-30 22:09:45 PDT 
Committed r292141 (249048@main): <https://commits.webkit.org/249048@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 456180 [details].
Comment 6 Radar WebKit Bug Importer 2022-03-30 22:10:17 PDT 
<rdar://problem/91085159>