Bug 238481 - [GLIB] Ubuntu LTS build broken after r291956
Summary: [GLIB] Ubuntu LTS build broken after r291956
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Diego Pino
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-03-28 19:29 PDT by Diego Pino
Modified: 2022-03-29 18:59 PDT (History)
12 users (show)

See Also:

Attachments
Patch (2.12 KB, patch)
2022-03-28 19:40 PDT, Diego Pino 		no flags Details | Formatted Diff | Diff
Patch (2.10 KB, patch)
2022-03-28 22:55 PDT, Diego Pino 		no flags Details | Formatted Diff | Diff
[fast-cq] Patch (2.13 KB, patch)
2022-03-29 17:33 PDT, Diego Pino 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Pino 2022-03-28 19:29:09 PDT 
[GLIB] Ubuntu LTS build broken after r291956
Comment 1 Diego Pino 2022-03-28 19:40:47 PDT 
Created attachment 455982 [details]
Patch
Comment 2 Diego Pino 2022-03-28 19:43:42 PDT 
Ubuntu LTS build bot error:

```
../../Source/WebCore/rendering/style/StyleGridData.h:47:59: error: ‘bool WebCore::GridTrackEntrySubgrid::operator==(const WebCore::GridTrackEntrySubgrid&) const’ cannot be defaulted
   47 |     bool operator==(const GridTrackEntrySubgrid&) const = default;
      |                                                           ^~~~~~~
../../Source/WebCore/rendering/style/StyleGridData.h:50:58: error: ‘bool WebCore::GridTrackEntryRepeat::operator==(const WebCore::GridTrackEntryRepeat&) const’ cannot be defaulted
   50 |     bool operator==(const GridTrackEntryRepeat&) const = default;
      |                                                          ^~~~~~~
../../Source/WebCore/rendering/style/StyleGridData.h:56:62: error: ‘bool WebCore::GridTrackEntryAutoRepeat::operator==(const WebCore::GridTrackEntryAutoRepeat&) const’ cannot be defaulted
   56 |     bool operator==(const GridTrackEntryAutoRepeat&) const = default;
      |                                                              ^~~~~~~
```

https://build.webkit.org/#/builders/68/builds/12315/steps/8/logs/stdio
Comment 3 Diego Pino 2022-03-28 22:55:27 PDT 
Created attachment 455998 [details]
Patch
Comment 4 Darin Adler 2022-03-29 15:34:13 PDT 
Comment on attachment 455998 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455998&action=review

> Source/WebCore/ChangeLog:3
> +        [GLIB] Ubuntu LTS build broken after r291956

There should not be a "[GLIB]" prefix on a bug like this. I know our rule might be confusing. A "you used a non-portable feature that GCC doesn’t support yet" bug doesn’t need a platform prefix. Or if it did have one, it would be "[GCC]".
Comment 5 EWS 2022-03-29 17:22:03 PDT 
/Volumes/Data/worker/Commit-Queue/build/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
Comment 6 Diego Pino 2022-03-29 17:33:43 PDT 
Created attachment 456082 [details]
[fast-cq] Patch
Comment 7 EWS 2022-03-29 18:58:14 PDT 
Committed r292094 (249014@main): <https://commits.webkit.org/249014@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 456082 [details].
Comment 8 Radar WebKit Bug Importer 2022-03-29 18:59:17 PDT 
<rdar://problem/91018313>