Bug 238477 - [WebXR][Cocoa] Enable GL_OES_EGL_image extension when makeXRCompatible() is called on GL context
Summary: [WebXR][Cocoa] Enable GL_OES_EGL_image extension when makeXRCompatible() is c...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ada Chan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-03-28 16:41 PDT by Ada Chan
Modified: 2022-03-28 20:08 PDT (History)
8 users (show)

See Also:

Attachments
Patch (1.72 KB, patch)
2022-03-28 16:44 PDT, Ada Chan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ada Chan 2022-03-28 16:41:59 PDT 
[WebXR][Cocoa] Enable GL_OES_EGL_image extension when makeXRCompatible() is called on GL context
Comment 1 Ada Chan 2022-03-28 16:44:17 PDT 
Created attachment 455969 [details]
Patch
Comment 2 Dean Jackson 2022-03-28 16:47:45 PDT 
Comment on attachment 455969 [details]
Patch

It's probably safe to do this unconditionally.
Comment 3 Ada Chan 2022-03-28 17:05:48 PDT 
(In reply to Dean Jackson from comment #2)
> Comment on attachment 455969 [details]
> Patch
> 
> It's probably safe to do this unconditionally.

The reason I did this with a guard is to match what's done here:
https://bugs.webkit.org/show_bug.cgi?id=228575
Comment 4 EWS 2022-03-28 20:07:16 PDT 
Committed r292021 (248965@main): <https://commits.webkit.org/248965@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 455969 [details].
Comment 5 Radar WebKit Bug Importer 2022-03-28 20:08:15 PDT 
<rdar://problem/90960584>