Bug 238430 - [WebGPU] Implement CommandEncoder::copyTextureToBuffer() according to the spec
Summary: [WebGPU] Implement CommandEncoder::copyTextureToBuffer() according to the spec
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on: 238428
Blocks:
  Show dependency tree / graph
 
Reported: 2022-03-27 19:09 PDT by Myles C. Maxfield
Modified: 2022-03-31 21:49 PDT (History)
4 users (show)

See Also:

Attachments
Patch (15.54 KB, patch)
2022-03-27 19:11 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (15.60 KB, patch)
2022-03-28 12:22 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (15.70 KB, patch)
2022-03-31 01:45 PDT, Myles C. Maxfield 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (15.71 KB, patch)
2022-03-31 01:48 PDT, Myles C. Maxfield 		dino: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2022-03-27 19:09:31 PDT 
.
Comment 1 Myles C. Maxfield 2022-03-27 19:11:43 PDT 
Created attachment 455876 [details]
Patch
Comment 2 Myles C. Maxfield 2022-03-28 12:22:21 PDT 
Created attachment 455941 [details]
Patch
Comment 3 Myles C. Maxfield 2022-03-31 01:45:22 PDT 
Created attachment 456217 [details]
Patch
Comment 4 Myles C. Maxfield 2022-03-31 01:48:53 PDT 
Created attachment 456218 [details]
Patch
Comment 5 Dean Jackson 2022-03-31 16:31:10 PDT 
Comment on attachment 456218 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456218&action=review

> Source/WebGPU/WebGPU/CommandEncoder.mm:359
> +    // "Let srcTextureDesc be source.texture.[[descriptor]]."

This is the first time I've seen this style of spec inclusion. Do we normally include quotation marks.

The style I've seen is a link at the top of the function, and then the comments are simply copied in (with the spec items numbers, if needed)
Comment 6 Myles C. Maxfield 2022-03-31 21:45:32 PDT 
Comment on attachment 456218 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=456218&action=review

>> Source/WebGPU/WebGPU/CommandEncoder.mm:359
>> +    // "Let srcTextureDesc be source.texture.[[descriptor]]."
> 
> This is the first time I've seen this style of spec inclusion. Do we normally include quotation marks.
> 
> The style I've seen is a link at the top of the function, and then the comments are simply copied in (with the spec items numbers, if needed)

Without quotation marks, how do you know what's a quote and what isn't?

You're not the first one to complain about this style, so maybe I should just get rid of all these kinds of comments altogether. I seem to be the only one that thinks they're valuable. I'll do it in a follow-up patch.
Comment 7 Myles C. Maxfield 2022-03-31 21:48:22 PDT 
Committed r292199 (249102@trunk): <https://commits.webkit.org/249102@trunk>
Comment 8 Radar WebKit Bug Importer 2022-03-31 21:49:18 PDT 
<rdar://problem/91144781>