Bug 238422 - Drop unnecessary isReachableFromDOM() function in JSNodeCustom.cpp
Summary: Drop unnecessary isReachableFromDOM() function in JSNodeCustom.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-03-26 16:26 PDT by Chris Dumez
Modified: 2022-03-28 07:15 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.82 KB, patch)
2022-03-26 16:27 PDT, Chris Dumez 		peng.liu6: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2022-03-26 16:26:18 PDT 
Drop unnecessary isReachableFromDOM() function in JSNodeCustom.cpp and inline its implementation in the only caller instead.
Comment 1 Chris Dumez 2022-03-26 16:27:20 PDT 
Created attachment 455859 [details]
Patch
Comment 2 Peng Liu 2022-03-26 21:01:35 PDT 
Comment on attachment 455859 [details]
Patch

Nice cleanup.
Comment 3 Chris Dumez 2022-03-26 22:04:19 PDT 
Comment on attachment 455859 [details]
Patch

Thanks for reviewing!
Comment 4 EWS 2022-03-26 22:04:43 PDT 
peng.liu6@icloud.com does not have reviewer permissions according to https://raw.githubusercontent.com/WebKit/WebKit/main/metadata/contributors.json.

Rejecting attachment 455859 [details] from commit queue.
Comment 5 Chris Dumez 2022-03-26 22:05:37 PDT 
(In reply to EWS from comment #4)
> peng.liu6@icloud.com does not have reviewer permissions according to
> https://raw.githubusercontent.com/WebKit/WebKit/main/metadata/contributors.
> json.
> 
> Rejecting attachment 455859 [details] from commit queue.

Looks like you will need to update your email in contributors.json Peng.
Comment 6 Chris Dumez 2022-03-28 07:14:17 PDT 
Committed r291963 (248928@trunk): <https://commits.webkit.org/248928@trunk>
Comment 7 Radar WebKit Bug Importer 2022-03-28 07:15:21 PDT 
<rdar://problem/90920497>