Bug 238394 - [WPE][GTK] Dist/distcheck targets fail due to Python error
Summary: [WPE][GTK] Dist/distcheck targets fail due to Python error
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adrian Perez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-03-25 15:08 PDT by Adrian Perez
Modified: 2022-04-21 03:10 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.77 KB, patch)
2022-03-25 15:12 PDT, Adrian Perez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adrian Perez 2022-03-25 15:08:17 PDT
Running “Tools/Scripts/build-webkit --wpe --makeargs=distcheck”:

[9/10] Checking release tarball: wpewebkit-2.36.0.tar
Traceback (most recent call last):
  File "/app/webkit/Tools/Scripts/make-dist", line 341, in <module>
    manifest = Manifest(arguments.manifest_filename, arguments.source_dir, arguments.build_dir, tarball_root)
  File "/app/webkit/Tools/Scripts/make-dist", line 150, in __init__
    self.process_line(line)
  File "/app/webkit/Tools/Scripts/make-dist", line 188, in process_line
    self.add_directory(Directory(*self.get_source_and_tarball_paths_from_parts(parts)))
  File "/app/webkit/Tools/Scripts/make-dist", line 98, in __init__
    self.files_in_version_control = self.list_files_in_version_control()
  File "/app/webkit/Tools/Scripts/make-dist", line 112, in list_files_in_version_control
    return out.rstrip('\n').split('\n')
TypeError: a bytes-like object is required, not 'str'
Comment 1 Adrian Perez 2022-03-25 15:12:39 PDT
Created attachment 455801 [details]
Patch
Comment 2 EWS 2022-03-26 02:18:29 PDT
Committed r291934 (248905@main): <https://commits.webkit.org/248905@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 455801 [details].
Comment 3 Radar WebKit Bug Importer 2022-03-26 02:19:18 PDT
<rdar://problem/90873463>