Bug 238365 - Improve rebuilding of ruby subtrees
Summary: Improve rebuilding of ruby subtrees
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Frédéric Wang (:fredw)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-03-24 23:43 PDT by Frédéric Wang (:fredw)
Modified: 2022-03-25 02:18 PDT (History)
10 users (show)

See Also:

Attachments
Patch (5.21 KB, patch)
2022-03-24 23:54 PDT, Frédéric Wang (:fredw) 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (5.21 KB, patch)
2022-03-24 23:59 PDT, Frédéric Wang (:fredw) 		no flags Details | Formatted Diff | Diff
Patch (11.42 KB, patch)
2022-03-25 01:25 PDT, Frédéric Wang (:fredw) 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Frédéric Wang (:fredw) 2022-03-24 23:43:07 PDT 
Should better handle anonymous before/after nodes.
Comment 1 Frédéric Wang (:fredw) 2022-03-24 23:54:50 PDT 
Created attachment 455731 [details]
Patch
Comment 2 EWS 2022-03-24 23:56:12 PDT 
Zalan Bujtas found in /Volumes/Data/worker/Commit-Queue/build/Source/WebCore/ChangeLog does not appear to be a valid reviewer according to contributors.json.
/Volumes/Data/worker/Commit-Queue/build/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
Comment 3 Frédéric Wang (:fredw) 2022-03-24 23:59:14 PDT 
Created attachment 455733 [details]
Patch
Comment 4 Frédéric Wang (:fredw) 2022-03-25 01:20:38 PDT 
Comment on attachment 455733 [details]
Patch

need to update test expectation
Comment 5 Frédéric Wang (:fredw) 2022-03-25 01:25:26 PDT 
Created attachment 455738 [details]
Patch
Comment 6 EWS 2022-03-25 02:17:02 PDT 
Committed r291852 (248864@main): <https://commits.webkit.org/248864@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 455738 [details].
Comment 7 Radar WebKit Bug Importer 2022-03-25 02:18:15 PDT 
<rdar://problem/90826382>