Bug 238351 - After r291814, we need to create the INSTALL_PATH for the iOS sandbox files
Summary: After r291814, we need to create the INSTALL_PATH for the iOS sandbox files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-03-24 15:51 PDT by Michael Saboff
Modified: 2022-03-24 16:38 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.65 KB, patch)
2022-03-24 16:03 PDT, Michael Saboff 		saam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2022-03-24 15:51:10 PDT 
Before r291814, some of the iOS sandbox files were copied to $(INSTALL_PATH).  That built in Xcode copying stpe created the INSTALL_PATH directory.  When the output of the preprocessed .sb.in files where copied to $(INSTALL_PATH), it already existed.  r291814 made it so that all of the iOS sandbox files are preprocessed and then copied to $(INSTALL_PATH) using the "cp" command.  The problem is that $(INSTALL_PATH) hasn't been created yet.

This appears to only manifest in the Apple build system and not local builds.
Comment 1 Michael Saboff 2022-03-24 15:51:28 PDT 
<rdar://90794287>
Comment 2 Michael Saboff 2022-03-24 16:03:06 PDT 
Created attachment 455698 [details]
Patch
Comment 3 Saam Barati 2022-03-24 16:07:11 PDT 
Comment on attachment 455698 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455698&action=review

r=me

> Source/WebKit/ChangeLog:11
> +        That change set made it soe that all WebKit iOS sandbox profile files are preprocessed

soe => so
Comment 4 Alexey Proskuryakov 2022-03-24 16:24:09 PDT 
I was going to ask if we need to add the directory to output paths because of this, then noticed that there aren't any inputs or outputs here.
Comment 5 Michael Saboff 2022-03-24 16:38:40 PDT 
Committed r291828 (248850@trunk): <https://commits.webkit.org/248850@trunk>