Bug 238344 - FileSystem::pathByAppendingComponent() should take in StringViews instead of Strings
Summary: FileSystem::pathByAppendingComponent() should take in StringViews instead of ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-03-24 12:52 PDT by Chris Dumez
Modified: 2022-03-25 08:55 PDT (History)
20 users (show)

See Also:

Attachments
Patch (35.23 KB, patch)
2022-03-24 13:31 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (35.08 KB, patch)
2022-03-24 13:37 PDT, Chris Dumez 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (36.14 KB, patch)
2022-03-24 14:04 PDT, Chris Dumez 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (36.28 KB, patch)
2022-03-24 17:48 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2022-03-24 12:52:19 PDT 
FileSystem::pathByAppendingComponent() should take in StringViews instead of Strings, to avoid unnecessary String constructor in many instances.
Comment 1 Chris Dumez 2022-03-24 13:31:26 PDT 
Created attachment 455671 [details]
Patch
Comment 2 Chris Dumez 2022-03-24 13:37:16 PDT 
Created attachment 455673 [details]
Patch
Comment 3 Chris Dumez 2022-03-24 14:04:20 PDT 
Created attachment 455678 [details]
Patch
Comment 4 Geoffrey Garen 2022-03-24 16:08:46 PDT 
Comment on attachment 455678 [details]
Patch

r=me
Comment 5 EWS 2022-03-24 17:17:17 PDT 
Tools/Scripts/svn-apply failed to apply attachment 455678 [details] to trunk.
Please resolve the conflicts and upload a new patch.
Comment 6 Chris Dumez 2022-03-24 17:48:41 PDT 
Created attachment 455714 [details]
Patch
Comment 7 EWS 2022-03-24 19:06:21 PDT 
Committed r291842 (248856@main): <https://commits.webkit.org/248856@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 455714 [details].
Comment 8 Radar WebKit Bug Importer 2022-03-24 19:07:17 PDT 
<rdar://problem/90811502>
Comment 9 Wenson Hsieh 2022-03-25 08:55:50 PDT 
Committed r291854 (248866@trunk): <https://commits.webkit.org/248866@trunk>