Bug 238336 - Start preparing WebCore for making the String(const char*) constructor explicit
Summary: Start preparing WebCore for making the String(const char*) constructor explicit
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks: 238693
  Show dependency tree / graph
 
Reported: 2022-03-24 10:51 PDT by Chris Dumez
Modified: 2022-04-01 19:56 PDT (History)
52 users (show)

See Also:

Attachments
Patch (415.80 KB, patch)
2022-03-24 13:16 PDT, Chris Dumez 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (421.05 KB, patch)
2022-03-24 13:32 PDT, Chris Dumez 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (421.06 KB, patch)
2022-03-24 14:51 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (423.63 KB, patch)
2022-03-24 14:56 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (423.63 KB, patch)
2022-03-24 16:14 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (419.56 KB, patch)
2022-03-24 17:44 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (416.82 KB, patch)
2022-03-24 19:48 PDT, Chris Dumez 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (411.77 KB, patch)
2022-03-24 20:59 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (411.36 KB, patch)
2022-03-24 21:58 PDT, Chris Dumez 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (411.72 KB, patch)
2022-03-24 22:37 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (412.49 KB, patch)
2022-03-25 07:23 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (10) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2022-03-24 10:51:22 PDT 
Start preparing WebCore for making the String(const char*) constructor explicit.
Making this constructor explicit helps catch at compile time cases where the ""_s prefix is missing on String literals.
Comment 1 Chris Dumez 2022-03-24 13:16:46 PDT 
Created attachment 455670 [details]
Patch
Comment 2 Chris Dumez 2022-03-24 13:32:15 PDT 
Created attachment 455672 [details]
Patch
Comment 3 Chris Dumez 2022-03-24 14:51:44 PDT 
Created attachment 455688 [details]
Patch
Comment 4 Chris Dumez 2022-03-24 14:56:14 PDT 
Created attachment 455691 [details]
Patch
Comment 5 Chris Dumez 2022-03-24 16:14:34 PDT 
Created attachment 455700 [details]
Patch
Comment 6 Chris Dumez 2022-03-24 17:44:36 PDT 
Created attachment 455713 [details]
Patch
Comment 7 Chris Dumez 2022-03-24 19:48:58 PDT 
Created attachment 455719 [details]
Patch
Comment 8 Chris Dumez 2022-03-24 20:59:47 PDT 
Created attachment 455722 [details]
Patch
Comment 9 Chris Dumez 2022-03-24 21:58:44 PDT 
Created attachment 455723 [details]
Patch
Comment 10 Chris Dumez 2022-03-24 22:37:54 PDT 
Created attachment 455724 [details]
Patch
Comment 11 Chris Dumez 2022-03-25 07:23:10 PDT 
Created attachment 455757 [details]
Patch
Comment 12 Geoffrey Garen 2022-03-25 10:01:24 PDT 
Comment on attachment 455757 [details]
Patch

r=me
Comment 13 Chris Dumez 2022-03-25 10:13:20 PDT 
Comment on attachment 455757 [details]
Patch

Clearing flags on attachment: 455757

Committed r291863 (248870@trunk): <https://commits.webkit.org/248870@trunk>
Comment 14 Chris Dumez 2022-03-25 10:13:28 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 15 Radar WebKit Bug Importer 2022-03-25 10:14:21 PDT 
<rdar://problem/90843719>