Bug 238228 - [LFC][IFC] Do not construct a TextRun for measuring a single whitespace when simplified content measuring can be used
Summary: [LFC][IFC] Do not construct a TextRun for measuring a single whitespace when ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-03-22 15:21 PDT by zalan
Modified: 2022-03-24 08:57 PDT (History)
5 users (show)

See Also:

Attachments
Patch (7.36 KB, patch)
2022-03-22 15:24 PDT, zalan 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (11.43 KB, patch)
2022-03-22 20:21 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (11.43 KB, patch)
2022-03-24 08:08 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2022-03-22 15:21:24 PDT 
ssia
Comment 1 zalan 2022-03-22 15:24:06 PDT 
Created attachment 455438 [details]
Patch
Comment 2 zalan 2022-03-22 20:21:50 PDT 
Created attachment 455467 [details]
Patch
Comment 3 Antti Koivisto 2022-03-24 06:32:20 PDT 
Comment on attachment 455467 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455467&action=review

> Source/WebCore/layout/formattingContexts/inline/text/TextUtil.cpp:67
> +    float width = 0.f;

auto!
Comment 4 zalan 2022-03-24 08:08:48 PDT 
Created attachment 455640 [details]
Patch
Comment 5 EWS 2022-03-24 08:56:47 PDT 
Committed r291799 (248827@main): <https://commits.webkit.org/248827@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 455640 [details].
Comment 6 Radar WebKit Bug Importer 2022-03-24 08:57:17 PDT 
<rdar://problem/90770755>