Bug 238205 - [LegacyLineLayout] Use the simplified text measuring in RenderText when applicable
Summary: [LegacyLineLayout] Use the simplified text measuring in RenderText when appli...
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-03-22 10:17 PDT by zalan
Modified: 2022-03-29 10:18 PDT (History)
12 users (show)

See Also:


Attachments
Patch (3.35 KB, patch)
2022-03-22 10:21 PDT, zalan
koivisto: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2022-03-22 10:17:44 PDT
ssia
Comment 1 zalan 2022-03-22 10:21:27 PDT
Created attachment 455389 [details]
Patch
Comment 2 Antti Koivisto 2022-03-22 10:23:33 PDT
Comment on attachment 455389 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455389&action=review

> Source/WebCore/rendering/RenderText.cpp:1568
> +            width = widthFromCache(fontCascade, from, len, xPos, fallbackFonts, glyphOverflow, style);
> +    } else if (canUseSimplifiedTextMeasuring())
> +        width = fontCascade.widthForSimpleText(StringView(text()).substring(from, len), style.direction());

no lambda😤
Comment 3 Radar WebKit Bug Importer 2022-03-29 10:18:43 PDT
<rdar://problem/90990081>