Bug 238160 - It should be possible to copy text out of “AutoFilledAndViewable” password fields
Summary: It should be possible to copy text out of “AutoFilledAndViewable” password fi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ricky Mondello
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-03-21 15:59 PDT by Ricky Mondello
Modified: 2022-03-22 11:50 PDT (History)
6 users (show)

See Also:

Attachments
Patch (4.61 KB, patch)
2022-03-21 16:05 PDT, Ricky Mondello 		no flags Details | Formatted Diff | Diff
Patch (4.60 KB, patch)
2022-03-21 16:07 PDT, Ricky Mondello 		no flags Details | Formatted Diff | Diff
Patch (4.53 KB, patch)
2022-03-21 16:18 PDT, Ricky Mondello 		ggaren: review+
Details | Formatted Diff | Diff
Patch (4.47 KB, patch)
2022-03-21 16:45 PDT, Ricky Mondello 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ricky Mondello 2022-03-21 15:59:58 PDT 
It should be possible to copy text out of “AutoFilledAndViewable” password fields
Comment 1 Ricky Mondello 2022-03-21 16:05:12 PDT 
Created attachment 455290 [details]
Patch
Comment 2 Ricky Mondello 2022-03-21 16:07:39 PDT 
Created attachment 455292 [details]
Patch
Comment 3 Ricky Mondello 2022-03-21 16:18:13 PDT 
Created attachment 455294 [details]
Patch
Comment 4 Geoffrey Garen 2022-03-21 16:26:17 PDT 
Comment on attachment 455294 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455294&action=review

r=me

> Source/WebCore/editing/VisibleSelection.cpp:686
> +bool VisibleSelection::isInAutoFilledAndViewablePasswordField() const

I think this helper function's usage would be more straight-forward if the function only computed "isInAutoFilledAndViewableField" and not also "isInPasswordField" -- since the caller already checks whether the selection is in a password field.
Comment 5 Ricky Mondello 2022-03-21 16:45:40 PDT 
Created attachment 455299 [details]
Patch
Comment 6 Ricky Mondello 2022-03-21 19:50:34 PDT 
rdar://90541951
Comment 7 Radar WebKit Bug Importer 2022-03-21 19:50:55 PDT 
<rdar://problem/90608844>
Comment 8 Geoffrey Garen 2022-03-22 08:49:26 PDT 
Comment on attachment 455299 [details]
Patch

r=me
Comment 9 EWS 2022-03-22 09:02:40 PDT 
Committed r291623 (248716@main): <https://commits.webkit.org/248716@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 455299 [details].