Bug 238107 - [IFC][Integration] Remove redundant InlineIterator::Line::contentLogicalTopAdjustedForHitTesting
Summary: [IFC][Integration] Remove redundant InlineIterator::Line::contentLogicalTopAd...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-03-18 21:20 PDT by zalan
Modified: 2022-03-20 08:06 PDT (History)
12 users (show)

See Also:

Attachments
Patch (7.77 KB, patch)
2022-03-18 21:28 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (10.94 KB, patch)
2022-03-19 22:12 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2022-03-18 21:20:20 PDT 
ssia
Comment 1 zalan 2022-03-18 21:28:50 PDT 
Created attachment 455164 [details]
Patch
Comment 2 Antti Koivisto 2022-03-19 05:52:05 PDT 
Comment on attachment 455164 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455164&action=review

> Source/WebCore/ChangeLog:9
> +        - containingBlock's borer and padding before

border

> Source/WebCore/layout/integration/InlineIteratorLineModernPath.h:-61
> -    float contentLogicalTopAdjustedForHitTesting() const { return !m_lineIndex ? containingBlock().borderAndPaddingBefore().toFloat() : contentLogicalTopAdjustedForPrecedingLine(); };

Did you forget to remove the LineLegacyPath version?
Comment 3 zalan 2022-03-19 22:12:02 PDT 
Created attachment 455188 [details]
Patch
Comment 4 EWS 2022-03-20 08:05:52 PDT 
Committed r291545 (248651@main): <https://commits.webkit.org/248651@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 455188 [details].
Comment 5 Radar WebKit Bug Importer 2022-03-20 08:06:18 PDT 
<rdar://problem/90538811>