Bug 238096 - Vector move constructor and move assignment operator are suboptimal when the vector has an inline buffer
Summary: Vector move constructor and move assignment operator are suboptimal when the ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-03-18 14:16 PDT by Chris Dumez
Modified: 2022-03-19 21:13 PDT (History)
7 users (show)

See Also:

Attachments
WIP Patch (10.84 KB, patch)
2022-03-18 14:18 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
WIP Patch (10.93 KB, patch)
2022-03-18 14:29 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (14.80 KB, patch)
2022-03-18 16:26 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (14.63 KB, patch)
2022-03-18 16:42 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (14.76 KB, patch)
2022-03-18 18:17 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (14.81 KB, patch)
2022-03-18 19:32 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2022-03-18 14:16:57 PDT 
The Vector move constructor and move assignment operator are suboptimal when the vector has an inline buffer, because it relies on Vector::swap().
Comment 1 Chris Dumez 2022-03-18 14:18:24 PDT 
Created attachment 455133 [details]
WIP Patch

Needs more testing and ASAN support.
Comment 2 Chris Dumez 2022-03-18 14:29:55 PDT 
Created attachment 455135 [details]
WIP Patch
Comment 3 Chris Dumez 2022-03-18 16:26:19 PDT 
Created attachment 455148 [details]
Patch
Comment 4 Chris Dumez 2022-03-18 16:42:59 PDT 
Created attachment 455151 [details]
Patch
Comment 5 Chris Dumez 2022-03-18 18:17:52 PDT 
Created attachment 455155 [details]
Patch
Comment 6 Chris Dumez 2022-03-18 19:32:45 PDT 
Created attachment 455158 [details]
Patch
Comment 7 Chris Dumez 2022-03-19 13:26:20 PDT 
Small 0.4% progression on Speedometer on MacBook Air 10,1 (Apple Silicon) confirmed by A/B bots.
Comment 8 EWS 2022-03-19 21:12:39 PDT 
Committed r291540 (248646@main): <https://commits.webkit.org/248646@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 455158 [details].
Comment 9 Radar WebKit Bug Importer 2022-03-19 21:13:16 PDT 
<rdar://problem/90532213>