Bug 238084 - [IFC][Integration] InlineIterator::Line::enclosingBottom should read enclosingBottomAdjustedForFollowingLine
Summary: [IFC][Integration] InlineIterator::Line::enclosingBottom should read enclosin...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-03-18 10:52 PDT by zalan
Modified: 2022-03-19 11:23 PDT (History)
5 users (show)

See Also:

Attachments
Patch (4.63 KB, patch)
2022-03-18 10:53 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (7.47 KB, patch)
2022-03-18 11:10 PDT, zalan 		no flags Details | Formatted Diff | Diff
[fast-cq]Patch (7.47 KB, patch)
2022-03-18 12:31 PDT, zalan 		no flags Details | Formatted Diff | Diff
[fast-cq]Patch (7.47 KB, patch)
2022-03-19 11:19 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2022-03-18 10:52:56 PDT 
ssia
Comment 1 zalan 2022-03-18 10:53:53 PDT 
Created attachment 455111 [details]
Patch
Comment 2 zalan 2022-03-18 11:10:41 PDT 
Created attachment 455113 [details]
Patch
Comment 3 Antti Koivisto 2022-03-18 11:32:36 PDT 
Comment on attachment 455113 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455113&action=review

> Source/WebCore/layout/integration/InlineIteratorLine.h:99
> +    LayoutUnit enclosingBottomAdjustedForFollowingLine() const;
>      LayoutUnit enclosingTopAdjustedForPrecedingLine() const;

Top to the top!
Comment 4 zalan 2022-03-18 12:31:06 PDT 
Created attachment 455126 [details]
[fast-cq]Patch
Comment 5 zalan 2022-03-19 11:19:15 PDT 
Created attachment 455168 [details]
[fast-cq]Patch
Comment 6 EWS 2022-03-19 11:22:54 PDT 
Committed r291529 (248635@main): <https://commits.webkit.org/248635@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 455168 [details].
Comment 7 Radar WebKit Bug Importer 2022-03-19 11:23:19 PDT 
<rdar://problem/90526693>