Bug 238079 - [IFC][Integration] InlineIterator::Line::enclosingTop is really an enclosingTopAdjustedForPrecedingLine
Summary: [IFC][Integration] InlineIterator::Line::enclosingTop is really an enclosingT...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-03-18 09:24 PDT by zalan
Modified: 2022-03-18 17:43 PDT (History)
5 users (show)

See Also:

Attachments
Patch (7.66 KB, patch)
2022-03-18 09:27 PDT, zalan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2022-03-18 09:24:38 PDT 
ssia
Comment 1 zalan 2022-03-18 09:27:08 PDT 
Created attachment 455099 [details]
Patch
Comment 2 Antti Koivisto 2022-03-18 09:57:41 PDT 
Comment on attachment 455099 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=455099&action=review

> Source/WebCore/layout/integration/InlineIteratorLine.h:98
> -    LayoutUnit enclosingTop() const;
>      LayoutUnit enclosingBottom() const;

enclosingBottom looks lonely now.
Comment 3 zalan 2022-03-18 10:02:17 PDT 
(In reply to Antti Koivisto from comment #2)
> Comment on attachment 455099 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=455099&action=review
> 
> > Source/WebCore/layout/integration/InlineIteratorLine.h:98
> > -    LayoutUnit enclosingTop() const;
> >      LayoutUnit enclosingBottom() const;
> 
> enclosingBottom looks lonely now.
not for long!
Comment 4 EWS 2022-03-18 14:24:12 PDT 
Found 1 new test failure: imported/w3c/web-platform-tests/workers/interfaces/WorkerUtils/importScripts/report-error-setTimeout-redirect-to-cross-origin.sub.any.worker.html
Comment 5 EWS 2022-03-18 17:42:04 PDT 
Committed r291512 (248618@main): <https://commits.webkit.org/248618@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 455099 [details].
Comment 6 Radar WebKit Bug Importer 2022-03-18 17:43:14 PDT 
<rdar://problem/90512456>