Bug 238028 - [GStreamer] Add stop position to the range request
Summary: [GStreamer] Add stop position to the range request
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Enrique Ocaña
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-03-17 10:54 PDT by Enrique Ocaña
Modified: 2022-03-18 09:47 PDT (History)
3 users (show)

See Also:


Attachments
Patch (2.82 KB, patch)
2022-03-17 11:29 PDT, Enrique Ocaña
no flags Details | Formatted Diff | Diff
Patch (2.82 KB, patch)
2022-03-18 05:46 PDT, Enrique Ocaña
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Enrique Ocaña 2022-03-17 10:54:26 PDT
Currently, the range requests performed by WebKitWebSourceGStreamer indicate a range start position but not a range stop one, even though it's set in the internal members->stopPosition attribute.
Comment 1 Enrique Ocaña 2022-03-17 11:29:24 PDT
Created attachment 454997 [details]
Patch
Comment 2 Philippe Normand 2022-03-17 11:48:34 PDT
Comment on attachment 454997 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454997&action=review

> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:680
> +            formatedRange.reset(g_strdup_printf("bytes=%" G_GUINT64_FORMAT "-%" G_GUINT64_FORMAT, members->requestedPosition, (members->stopPosition > 0) ? members->stopPosition - 1 : 0));

The wrapping parentheses are not needed.
Comment 3 Adam Podolnick 2022-03-17 13:59:30 PDT
Is this a regression of this: https://bugs.webkit.org/show_bug.cgi?id=236401 ?

We have a customer that's having an issue playing videos within an embedded WebView in FileMaker Pro on macOS 12.3. While this bug appears to have been fixed in Safari proper, it looks like it's still broken in embedded WebViews.

If this isn't related, let me know and I'll file a new bug.
Comment 4 Philippe Normand 2022-03-17 14:35:25 PDT
The GStreamer backend is not used by the mac ports, so I doubt this patch will solve your issues.
Comment 5 Enrique Ocaña 2022-03-18 05:46:00 PDT
Created attachment 455090 [details]
Patch
Comment 6 EWS 2022-03-18 08:35:17 PDT
Found 2 new test failures: imported/w3c/web-platform-tests/workers/interfaces/WorkerUtils/importScripts/report-error-setTimeout-cross-origin.sub.any.worker.html, imported/w3c/web-platform-tests/workers/interfaces/WorkerUtils/importScripts/report-error-setTimeout-redirect-to-cross-origin.sub.any.worker.html
Comment 7 EWS 2022-03-18 09:46:58 PDT
Committed r291487 (248601@main): <https://commits.webkit.org/248601@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 455090 [details].
Comment 8 Radar WebKit Bug Importer 2022-03-18 09:47:19 PDT
<rdar://problem/90490318>