Bug 238026 - Removed telemetry from Networking.sb
Summary: Removed telemetry from Networking.sb
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Local Build
Hardware: iPhone / iPad Unspecified
: P2 Normal
Assignee: Adam Mazander
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-03-17 08:33 PDT by Adam Mazander
Modified: 2022-03-17 13:15 PDT (History)
4 users (show)

See Also:

Attachments
Patch (15.28 KB, patch)
2022-03-17 09:02 PDT, Adam Mazander 		no flags Details | Formatted Diff | Diff
Patch (16.36 KB, patch)
2022-03-17 10:00 PDT, Adam Mazander 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Mazander 2022-03-17 08:33:11 PDT 
Remove unused telemetry from Networking.sb on iOS
Comment 1 Adam Mazander 2022-03-17 09:02:27 PDT 
Created attachment 454979 [details]
Patch
Comment 2 Adam Mazander 2022-03-17 09:06:05 PDT 
<rdar://90431433>
Comment 3 Per Arne Vollan 2022-03-17 09:13:06 PDT 
Comment on attachment 454979 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454979&action=review

> Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:231
>          (allow network-outbound (with telemetry) (apply require-any filters))))

It does not look like all telemetry is removed. Should we remove the remaining ones as well?
Comment 4 Adam Mazander 2022-03-17 10:00:47 PDT 
Created attachment 454985 [details]
Patch
Comment 5 Adam Mazander 2022-03-17 10:02:19 PDT 
Yes we have enough data, thanks Per
Comment 6 Per Arne Vollan 2022-03-17 10:04:09 PDT 
Comment on attachment 454985 [details]
Patch

R=me.
Comment 7 EWS 2022-03-17 13:00:01 PDT 
Found 1 new test failure: imported/w3c/web-platform-tests/css/css-contain/content-visibility/content-visibility-050.html
Comment 8 EWS 2022-03-17 13:15:48 PDT 
Committed r291433 (248558@main): <https://commits.webkit.org/248558@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 454985 [details].