Bug 238004 - Adjust anchor/focus nodes after removal when LiveRangeSelection is enabled
Summary: Adjust anchor/focus nodes after removal when LiveRangeSelection is enabled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Frédéric Wang (:fredw)
URL:
Keywords: InRadar
Depends on:
Blocks: 220514
  Show dependency tree / graph
 
Reported: 2022-03-16 23:54 PDT by Frédéric Wang (:fredw)
Modified: 2022-03-22 00:23 PDT (History)
5 users (show)

See Also:

Attachments
Patch (4.84 KB, patch)
2022-03-17 00:04 PDT, Frédéric Wang (:fredw) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Frédéric Wang (:fredw) 2022-03-16 23:54:44 PDT 
.
Comment 1 Frédéric Wang (:fredw) 2022-03-17 00:04:41 PDT 
Created attachment 454936 [details]
Patch
Comment 2 Frédéric Wang (:fredw) 2022-03-21 23:48:05 PDT 
Comment on attachment 454936 [details]
Patch

Regarding the mac-AS-debug-wk2 failure: I cannot reproduce the crashes locally + the tests don't seem to enable LiveRangeSelection or use selection API + I see that other builds had similar issues e.g.

https://ews-build.webkit.org/#/builders/60/builds/26993
https://ews-build.webkit.org/#/builders/60/builds/26814
https://ews-build.webkit.org/#/builders/60/builds/26792
https://ews-build.webkit.org/#/builders/60/builds/26789

So I'll just land it.
Comment 3 EWS 2022-03-22 00:22:18 PDT 
Committed r291605 (248698@main): <https://commits.webkit.org/248698@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 454936 [details].
Comment 4 Radar WebKit Bug Importer 2022-03-22 00:23:15 PDT 
<rdar://problem/90618375>