Bug 237993 - compare-results should break down sync vs async time in Speedometer2
Summary: compare-results should break down sync vs async time in Speedometer2
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-03-16 17:38 PDT by Saam Barati
Modified: 2022-03-18 17:35 PDT (History)
3 users (show)

See Also:

Attachments
patch (3.56 KB, patch)
2022-03-16 17:44 PDT, Saam Barati 		ashvayka: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
[fast-cq] patch for landing (3.50 KB, patch)
2022-03-17 10:50 PDT, Saam Barati 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
[fast-cq] patch for landing (3.50 KB, patch)
2022-03-17 13:07 PDT, Saam Barati 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2022-03-16 17:38:32 PDT 
...
Comment 1 Saam Barati 2022-03-16 17:44:06 PDT 
Created attachment 454920 [details]
patch
Comment 2 Alexey Shvayka 2022-03-16 18:29:29 PDT 
Comment on attachment 454920 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454920&action=review

> Tools/Scripts/compare-results:77
> +    #print(json.dumps(breakdown._results, indent=4, sort_keys=True))

nit: remove debug comment?

> Tools/Scripts/compare-results:86
> +            if not syncTime:

nit: flip condition?
Comment 3 Saam Barati 2022-03-16 18:44:26 PDT 
Comment on attachment 454920 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454920&action=review

>> Tools/Scripts/compare-results:77
>> +    #print(json.dumps(breakdown._results, indent=4, sort_keys=True))
> 
> nit: remove debug comment?

Yeah good point :-)

>> Tools/Scripts/compare-results:86
>> +            if not syncTime:
> 
> nit: flip condition?

I kinda like the ordering style wise now
Comment 4 Saam Barati 2022-03-17 10:50:53 PDT 
Created attachment 454993 [details]
[fast-cq] patch for landing
Comment 5 EWS 2022-03-17 11:31:19 PDT 
Alexey Shvaika found in /Volumes/Data/worker/Commit-Queue/build/Tools/ChangeLog does not appear to be a valid reviewer according to contributors.json.
/Volumes/Data/worker/Commit-Queue/build/Tools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
Comment 6 Saam Barati 2022-03-17 13:07:27 PDT 
Created attachment 455010 [details]
[fast-cq] patch for landing
Comment 7 EWS 2022-03-17 13:23:31 PDT 
Committed r291436 (248560@main): <https://commits.webkit.org/248560@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 455010 [details].
Comment 8 Radar WebKit Bug Importer 2022-03-17 13:24:18 PDT 
<rdar://problem/90449305>
Comment 9 Alexey Proskuryakov 2022-03-18 17:35:28 PDT 
Silly question, what is "sync" and "async" here?