Bug 237963 - Pass style builder context to CSSToLengthConversionData
Summary: Pass style builder context to CSSToLengthConversionData
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antti Koivisto
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-03-16 08:59 PDT by Antti Koivisto
Modified: 2022-03-17 02:43 PDT (History)
17 users (show)

See Also:

Attachments
Patch (17.59 KB, patch)
2022-03-16 09:30 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Patch (21.52 KB, patch)
2022-03-16 10:36 PDT, Antti Koivisto 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (21.49 KB, patch)
2022-03-16 10:45 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Patch (22.98 KB, patch)
2022-03-16 11:56 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Patch (22.97 KB, patch)
2022-03-16 12:00 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Patch (22.46 KB, patch)
2022-03-16 13:13 PDT, Antti Koivisto 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2022-03-16 08:59:05 PDT 
Preparation for resolving container units.
Comment 1 Antti Koivisto 2022-03-16 09:30:08 PDT 
Created attachment 454846 [details]
Patch
Comment 2 Antti Koivisto 2022-03-16 10:36:16 PDT 
Created attachment 454857 [details]
Patch
Comment 3 Antti Koivisto 2022-03-16 10:45:00 PDT 
Created attachment 454862 [details]
Patch
Comment 4 Antti Koivisto 2022-03-16 11:56:50 PDT 
Created attachment 454874 [details]
Patch
Comment 5 Antti Koivisto 2022-03-16 12:00:31 PDT 
Created attachment 454876 [details]
Patch
Comment 6 Antti Koivisto 2022-03-16 13:13:42 PDT 
Created attachment 454886 [details]
Patch
Comment 7 Antoine Quint 2022-03-17 01:44:38 PDT 
Comment on attachment 454886 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454886&action=review

> Source/WebCore/css/CSSToLengthConversionData.h:52
> +    CSSToLengthConversionData(const RenderStyle&, const RenderStyle* rootStyle, const RenderStyle* parentStyle, const RenderView*);

'zoom' v. `zoom`, who should win?

> Source/WebCore/css/MediaQueryEvaluator.cpp:949
> +    return function(expression.value(), { *m_style, &defaultStyle, nullptr, document.renderView() }, *frame, NoPrefix);

Should we ASSERT(m_style) here?
Comment 8 Antti Koivisto 2022-03-17 01:53:11 PDT 
> Should we ASSERT(m_style) here?

Nah, there is a null test pretty close above.
Comment 9 EWS 2022-03-17 02:42:16 PDT 
Committed r291398 (248528@main): <https://commits.webkit.org/248528@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 454886 [details].
Comment 10 Radar WebKit Bug Importer 2022-03-17 02:43:18 PDT 
<rdar://problem/90419727>