Bug 237952 - WebGL context lost event is not sent again for contexts that are lost and restored
Summary: WebGL context lost event is not sent again for contexts that are lost and res...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kimmo Kinnunen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-03-16 03:42 PDT by Kimmo Kinnunen
Modified: 2022-03-17 04:58 PDT (History)
11 users (show)

See Also:

Attachments
Patch (25.93 KB, patch)
2022-03-16 05:09 PDT, Kimmo Kinnunen 		no flags Details | Formatted Diff | Diff
Patch (25.71 KB, patch)
2022-03-16 05:11 PDT, Kimmo Kinnunen 		no flags Details | Formatted Diff | Diff
For landing (25.86 KB, patch)
2022-03-16 05:35 PDT, Kimmo Kinnunen 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kimmo Kinnunen 2022-03-16 03:42:32 PDT 
WebGL context lost event is not sent again for contexts that are lost and restored

The restored contexts do not set the GraphicsContextGL::Client
Comment 1 Kimmo Kinnunen 2022-03-16 05:09:47 PDT 
Created attachment 454823 [details]
Patch
Comment 2 Kimmo Kinnunen 2022-03-16 05:11:32 PDT 
Created attachment 454824 [details]
Patch
Comment 3 Kimmo Kinnunen 2022-03-16 05:35:05 PDT 
Created attachment 454828 [details]
For landing
Comment 4 Antti Koivisto 2022-03-16 05:35:36 PDT 
Comment on attachment 454824 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454824&action=review

> Source/WebCore/platform/graphics/GraphicsContextGL.h:1050
> +    void setClient(Client* client) { m_client = client; }

This could assert that m_client is null.
Comment 5 Antti Koivisto 2022-03-16 05:36:28 PDT 
...or that either m_client or client is null.
Comment 6 EWS 2022-03-17 03:08:28 PDT 
Committed r291399 (248529@main): <https://commits.webkit.org/248529@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 454828 [details].
Comment 7 Radar WebKit Bug Importer 2022-03-17 03:09:16 PDT 
<rdar://problem/90420387>