Bug 237913 - Make it clearer in the loading logging when it is for the main frame or not
Summary: Make it clearer in the loading logging when it is for the main frame or not
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-03-15 12:20 PDT by Chris Dumez
Modified: 2022-03-15 16:18 PDT (History)
10 users (show)

See Also:

Attachments
Patch (21.33 KB, patch)
2022-03-15 12:21 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (21.37 KB, patch)
2022-03-15 13:51 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2022-03-15 12:20:41 PDT 
Make it clearer in the loading logging when it is for the main frame or not.
Comment 1 Chris Dumez 2022-03-15 12:21:53 PDT 
Created attachment 454740 [details]
Patch
Comment 2 Alex Christensen 2022-03-15 13:49:46 PDT 
Comment on attachment 454740 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454740&action=review

> Source/WebCore/page/FrameView.cpp:147
> +#define FRAMEVIEW_RELEASE_LOG(channel, fmt, ...) RELEASE_LOG(channel, "%p - [pageID=%" PRIu64 ", frameID=%" PRIu64 ", isFrameFrame=%d] FrameView::" fmt, this, PAGE_ID, FRAME_ID, frame().isMainFrame(), ##__VA_ARGS__)

isFrameFrame
Comment 3 Chris Dumez 2022-03-15 13:51:31 PDT 
(In reply to Alex Christensen from comment #2)
> Comment on attachment 454740 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=454740&action=review
> 
> > Source/WebCore/page/FrameView.cpp:147
> > +#define FRAMEVIEW_RELEASE_LOG(channel, fmt, ...) RELEASE_LOG(channel, "%p - [pageID=%" PRIu64 ", frameID=%" PRIu64 ", isFrameFrame=%d] FrameView::" fmt, this, PAGE_ID, FRAME_ID, frame().isMainFrame(), ##__VA_ARGS__)
> 
> isFrameFrame

LOL, oops. thanks for catching.
Comment 4 Chris Dumez 2022-03-15 13:51:42 PDT 
Created attachment 454754 [details]
Patch
Comment 5 EWS 2022-03-15 16:17:12 PDT 
Committed r291320 (248459@main): <https://commits.webkit.org/248459@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 454754 [details].
Comment 6 Radar WebKit Bug Importer 2022-03-15 16:18:33 PDT 
<rdar://problem/90336857>