Bug 237869 - [WebGPU] Implement queue submission methods according to the spec
Summary: [WebGPU] Implement queue submission methods according to the spec
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGPU (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords: InRadar
Depends on: 237864
Blocks: 237583 237870
  Show dependency tree / graph
 
Reported: 2022-03-14 20:01 PDT by Myles C. Maxfield
Modified: 2022-03-16 19:30 PDT (History)
4 users (show)

See Also:

Attachments
Patch (6.43 KB, patch)
2022-03-14 20:13 PDT, Myles C. Maxfield 		no flags Details | Formatted Diff | Diff
Patch (6.50 KB, patch)
2022-03-14 20:14 PDT, Myles C. Maxfield 		kkinnunen: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2022-03-14 20:01:38 PDT 
.
Comment 1 Myles C. Maxfield 2022-03-14 20:13:22 PDT 
Created attachment 454655 [details]
Patch
Comment 2 Myles C. Maxfield 2022-03-14 20:14:41 PDT 
Created attachment 454656 [details]
Patch
Comment 3 Kimmo Kinnunen 2022-03-15 06:10:24 PDT 
Comment on attachment 454656 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454656&action=review

> Source/WebGPU/WebGPU/Queue.h:73
> +    using OnSubmittedWorkDoneCallbacks = Vector<WTF::Function<void(WGPUQueueWorkDoneStatus)>>;

completion handler aspect comes back also here.
so later on, you perhaps should switch the onsubmitted api signature to use completion handler, as the. intention is to express "this function is valid only for one call".
Comment 4 Myles C. Maxfield 2022-03-16 14:20:11 PDT 
Committed r291366 (248498@trunk): <https://commits.webkit.org/248498@trunk>
Comment 5 Radar WebKit Bug Importer 2022-03-16 14:21:17 PDT 
<rdar://problem/90391949>
Comment 6 Myles C. Maxfield 2022-03-16 19:30:33 PDT 
Committed r291382 (248513@trunk): <https://commits.webkit.org/248513@trunk>