Created attachment 454541 [details]
Patch

Comment on attachment 454541 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454541&action=review

r=me, neato :)

> Source/WebCore/editing/cocoa/WebContentReaderCocoa.mm:209
> +    return replacementType == ReplacementMethod::Attachment || !url.protocolIsInHTTPFamily();

NIT: I feel like this would read better as a separate if.
```
if (url.protocolIsInHTTPFamily())
    return replacementType == ReplacementMethod::Attachment;

return true;
```

Comment on attachment 454541 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454541&action=review

Thanks for the review!

>> Source/WebCore/editing/cocoa/WebContentReaderCocoa.mm:209
>> +    return replacementType == ReplacementMethod::Attachment || !url.protocolIsInHTTPFamily();
> 
> NIT: I feel like this would read better as a separate if.
> ```
> if (url.protocolIsInHTTPFamily())
>     return replacementType == ReplacementMethod::Attachment;
> 
> return true;
> ```

Sounds good — will change it to that.

Created attachment 454622 [details]
For landing

Committed r291261 (248413@main): <https://commits.webkit.org/248413@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 454622 [details].