Bug 237784 - Finish implementing modify-headers actions for WKContentRuleList SPI
Summary: Finish implementing modify-headers actions for WKContentRuleList SPI
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-03-11 09:34 PST by Alex Christensen
Modified: 2022-03-11 16:33 PST (History)
2 users (show)

See Also:

Attachments
Patch (16.39 KB, patch)
2022-03-11 09:35 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (19.74 KB, patch)
2022-03-11 14:42 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (19.70 KB, patch)
2022-03-11 15:21 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2022-03-11 09:34:04 PST 
Finish implementing modify-headers actions for WKContentRuleList SPI
Comment 1 Alex Christensen 2022-03-11 09:35:17 PST 
Created attachment 454490 [details]
Patch
Comment 2 Alex Christensen 2022-03-11 09:35:21 PST 
<rdar://problem/72433048>
Comment 3 Alex Christensen 2022-03-11 14:42:54 PST 
Created attachment 454513 [details]
Patch
Comment 4 Timothy Hatcher 2022-03-11 15:14:56 PST 
Comment on attachment 454513 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454513&action=review

> Source/WebCore/contentextensions/ContentExtensionActions.cpp:452
> +        return JSObjectGetPropertyForKey(context, toObject(value), JSValueMakeNumber(context, index), nullptr);

Can you use JSObjectGetPropertyAtIndex instead?
Comment 5 Alex Christensen 2022-03-11 15:21:49 PST 
Created attachment 454515 [details]
Patch
Comment 6 EWS 2022-03-11 16:33:28 PST 
Committed r291200 (248355@main): <https://commits.webkit.org/248355@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 454515 [details].