237731 – [Cocoa] Add a FairPlay keyserver and EME tests to LayoutTests

RESOLVED FIXED237731

[Cocoa] Add a FairPlay keyserver and EME tests to LayoutTests

https://bugs.webkit.org/show_bug.cgi?id=237731

Summary [Cocoa] Add a FairPlay keyserver and EME tests to LayoutTests

Jer Noble

Reported 2022-03-10 13:44:30 PST

[Cocoa] Add a FairPlay keyserver and EME tests to LayoutTests

Attachments
Patch (7.63 MB, patch) 2022-03-10 14:38 PST, Jer Noble	no flags	Details Formatted Diff Diff
Patch (2.68 KB, patch) 2022-03-11 11:42 PST, Jonathan Bedard	no flags	Details Formatted Diff Diff
Patch (7.64 MB, patch) 2022-03-13 13:14 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Patch (7.64 MB, patch) 2022-03-13 15:05 PDT, Jer Noble	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (7.64 MB, patch) 2022-03-14 09:19 PDT, Jer Noble	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (7.63 MB, patch) 2022-03-15 17:02 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Patch (7.63 MB, patch) 2022-03-16 08:21 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Patch (7.64 MB, patch) 2022-03-16 11:41 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Patch (7.64 MB, patch) 2022-03-16 12:13 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Patch (7.64 MB, patch) 2022-03-16 12:18 PDT, Jer Noble	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (7.64 MB, patch) 2022-03-20 22:32 PDT, Jer Noble	no flags	Details Formatted Diff Diff
Patch (7.64 MB, patch) 2022-03-23 15:03 PDT, Jer Noble	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch (7.64 MB, patch) 2022-03-23 16:44 PDT, Jer Noble	jer.noble: review? ews-feeder: commit-queue-	Details Formatted Diff Diff
Show Obsolete (12) View All Add attachment proposed patch, testcase, etc.

Jer Noble

Comment 1 2022-03-10 14:38:24 PST

Created attachment 454402 [details] Patch

Eric Carlson

Comment 2 2022-03-10 14:54:33 PST

Comment on attachment 454402 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454402&action=review > LayoutTests/ChangeLog:23 > + and persistable licenses. It currently only supports "modern" EME key requests, but acn s/acn/can/ > LayoutTests/ChangeLog:261 > +2022-03-10 Jer Noble <jer.noble@apple.com> > + > + [Cocoa] Add a FairPlay keyserver and EME tests to LayoutTests > + https://bugs.webkit.org/show_bug.cgi?id=237731 > + > + Reviewed by NOBODY (OOPS!). Double ChangeLog

Jonathan Bedard

Comment 3 2022-03-11 11:42:49 PST

Created attachment 454500 [details] Patch

Jer Noble

Comment 4 2022-03-13 13:14:42 PDT

Created attachment 454556 [details] Patch

Jer Noble

Comment 5 2022-03-13 15:05:28 PDT

Created attachment 454558 [details] Patch

Jer Noble

Comment 6 2022-03-13 23:27:09 PDT

``` [Sun Mar 13 15:35:39.040034 2022] [cgi:error] [pid 847] [client 127.0.0.1:62020] AH01215: ModuleNotFoundError: No module named 'OpenSSL': /Volumes/Data/worker/macOS-Release-WK2-Stress-Tests-EWS/build/LayoutTests/http/tests/media/fairplay/keyserver/index.py, referer: http://127.0.0.1:8000/media/fairplay/fps-mse-unmuxed-multiple-keys.html ``` Looks like we need to auto install the OpenSSL package as well.

Jonathan Bedard

Comment 7 2022-03-14 07:59:44 PDT

Comment on attachment 454558 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454558&action=review > LayoutTests/http/tests/media/fairplay/keyserver/keyserver/__init__.py:40 > + from webkitpy.autoinstalled.cryptography.hazmat.primitives.ciphers import modes `from webkitpy.autoinstalled import cryptography` should be sufficient for this. Also, once you do this once, "from cryptography.hazmat.primitives.ciphers import modes" should work.

Jer Noble

Comment 8 2022-03-14 09:19:05 PDT

Created attachment 454595 [details] Patch

Jer Noble

Comment 9 2022-03-15 17:02:08 PDT

Created attachment 454777 [details] Patch

Jer Noble

Comment 10 2022-03-16 08:21:01 PDT

Created attachment 454836 [details] Patch

Jer Noble

Comment 11 2022-03-16 10:08:37 PDT

Getting closer! The key server is now running correctly! Now to investigate the cause of the failing tests. I suspect it's just a harness problem.

Peng Liu

Comment 12 2022-03-16 10:57:47 PDT

Comment on attachment 454836 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=454836&action=review > LayoutTests/ChangeLog:23 > + and persistable licenses. It currently only supports "modern" EME key requests, but acn s/acn/can > LayoutTests/http/tests/media/fairplay/eme2016.js:15 > + method: 'POST', Nit. The indention. > LayoutTests/http/tests/media/fairplay/fps-hls-key-rotation.html:61 > + method: 'POST', Ditto. > LayoutTests/http/tests/media/fairplay/fps-hls-update-reject.html:52 > + method: 'POST', Ditto. > LayoutTests/http/tests/media/fairplay/fps-hls.html:53 > + method: 'POST', Ditto. > LayoutTests/http/tests/media/fairplay/fps-init-data-cenc.html:48 > + method: 'POST', Ditto. > LayoutTests/http/tests/media/fairplay/fps-init-data-sinf.html:45 > + method: 'POST', Ditto. > LayoutTests/http/tests/media/fairplay/keyserver/keyserver/test_DFunction.py:34 > +class TestDFunction(unittest.TestCase): Will bots run the test? :-)

Jer Noble

Comment 13 2022-03-16 11:41:22 PDT

Created attachment 454868 [details] Patch

Jer Noble

Comment 14 2022-03-16 12:13:55 PDT

Created attachment 454877 [details] Patch

Jer Noble

Comment 15 2022-03-16 12:18:41 PDT

Created attachment 454879 [details] Patch

Xabier Rodríguez Calvar

Comment 16 2022-03-17 00:22:25 PDT

I think there are some changes in this patch that need to be removed as they are unrelated and there is no changelog for them, right?

Jer Noble

Comment 17 2022-03-17 10:55:48 PDT

(In reply to Xabier Rodríguez Calvar from comment #16) > I think there are some changes in this patch that need to be removed as they > are unrelated and there is no changelog for them, right? Yes, I should remove the r? bit on this patch; I changed some of the promise rejections inside MediaKeySession to get more information about why the testes were failing on the stress bot.

Radar WebKit Bug Importer

Comment 18 2022-03-17 14:45:40 PDT

<rdar://problem/90453705>

Jer Noble

Comment 19 2022-03-17 22:12:17 PDT

Okay, the Mac-wk2-stress test bot is failing for a very interesting reason: we leak every RemoteCDMInstanceSessionProxy we create in the GPU Process. So after about 800 tests, FairPlay stops allowing additional sessions to be created. I'll include a fix with the next patch.

Jer Noble

Comment 20 2022-03-20 22:32:46 PDT

Created attachment 455213 [details] Patch

Jer Noble

Comment 21 2022-03-23 15:03:35 PDT

Created attachment 455565 [details] Patch

Jer Noble

Comment 22 2022-03-23 16:44:30 PDT

Created attachment 455584 [details] Patch

Jer Noble

Comment 23 2022-07-27 11:40:44 PDT

Pull request: https://github.com/WebKit/WebKit/pull/2786

EWS

Comment 24 2022-08-08 13:43:34 PDT

Committed 253230@main (809ad82ca6e2): <https://commits.webkit.org/253230@main> Reviewed commits have been landed. Closing PR #2786 and removing active labels.

Note You need to log in before you can comment on or make changes to this bug.

Status RESOLVED

Resolution FIXED

Priority P2

Severity Normal

Classification Unclassified

Version WebKit Nightly Build

Hardware Unspecified

OS Unspecified

Product WebKit

Component New Bugs

Assignee

Jer Noble

Reported

2022-03-10 13:44 PST

Modified

2022-08-08 13:43 PDT History

CC List

9 users Show

URL

Keywords InRadar

Depends on

Blocks