Bug 237620 - Enable CFPrefs direct mode in adattributiond
Summary: Enable CFPrefs direct mode in adattributiond
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-03-08 15:05 PST by Alex Christensen
Modified: 2022-03-08 16:54 PST (History)
2 users (show)

See Also:

Attachments
Patch (1.92 KB, patch)
2022-03-08 15:08 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (1.99 KB, patch)
2022-03-08 15:15 PST, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2022-03-08 15:05:32 PST 
Enable CFPrefs direct mode in adattributiond
Comment 1 Alex Christensen 2022-03-08 15:08:46 PST 
Created attachment 454155 [details]
Patch
Comment 2 Per Arne Vollan 2022-03-08 15:11:55 PST 
Comment on attachment 454155 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=454155&action=review

Nice! R=me.

> Source/WebKit/Shared/EntryPointUtilities/Cocoa/Daemon/PCMDaemonEntryPoint.mm:135
> +        _CFPrefsSetDirectModeEnabled(YES);

You could also enable CF prefs read only mode (_CFPrefsSetReadOnly). Have the CF prefs services already been removed from the sandbox?
Comment 3 Alex Christensen 2022-03-08 15:15:05 PST 
Created attachment 454156 [details]
Patch
Comment 4 Alex Christensen 2022-03-08 15:23:45 PST 
Comment on attachment 454156 [details]
Patch

They were never added to the sandbox, which is how I found this problem.
Comment 5 EWS 2022-03-08 16:54:00 PST 
Committed r291021 (248195@main): <https://commits.webkit.org/248195@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 454156 [details].
Comment 6 Radar WebKit Bug Importer 2022-03-08 16:54:21 PST 
<rdar://problem/89998171>