Bug 237530 - Make "true" count as truthy in window.open()'s boolean features
Summary: Make "true" count as truthy in window.open()'s boolean features
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-03-07 07:00 PST by Domenic Denicola
Modified: 2022-03-08 12:01 PST (History)
14 users (show)

See Also:

Attachments
Patch (21.80 KB, patch)
2022-03-07 08:19 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (1.70 KB, patch)
2022-03-08 11:59 PST, Cameron McCormack (:heycam) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Domenic Denicola 2022-03-07 07:00:45 PST 
See https://github.com/whatwg/html/pull/7425
Comment 1 Chris Dumez 2022-03-07 08:19:16 PST 
Created attachment 453988 [details]
Patch
Comment 2 Alex Christensen 2022-03-07 11:14:50 PST 
Comment on attachment 453988 [details]
Patch

"true" is the truthiest of words.
Comment 3 EWS 2022-03-07 11:22:35 PST 
Committed r290899 (248130@main): <https://commits.webkit.org/248130@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 453988 [details].
Comment 4 Radar WebKit Bug Importer 2022-03-07 11:23:18 PST 
<rdar://problem/89919539>
Comment 5 Cameron McCormack (:heycam) 2022-03-08 11:58:56 PST 
Reopening to attach new patch.
Comment 6 Cameron McCormack (:heycam) 2022-03-08 11:59:00 PST 
Created attachment 454139 [details]
Patch
Comment 7 Cameron McCormack (:heycam) 2022-03-08 12:00:43 PST 
Comment on attachment 454139 [details]
Patch

Bad ChangeLog position made webkit-patch upload to the wrong bug.