Bug 237504 - Fix JITOperationList::addPointers() to support JIT_OPERATION_VALIDATION_ASSERT_ENABLED.
Summary: Fix JITOperationList::addPointers() to support JIT_OPERATION_VALIDATION_ASSER...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-03-05 16:24 PST by Mark Lam
Modified: 2022-03-05 23:00 PST (History)
6 users (show)

See Also:

Attachments
[fast-cq] proposed patch. (1.91 KB, patch)
2022-03-05 16:26 PST, Mark Lam 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2022-03-05 16:24:19 PST 
According to tagJSCCodePtrImpl(), we will only use an operation's validation entry if Options::useJITCage().  Make JITOperationList::addPointers() conform to this.

<rdar://problem/89770507>
Comment 1 Mark Lam 2022-03-05 16:26:45 PST 
Created attachment 453923 [details]
[fast-cq] proposed patch.
Comment 2 Saam Barati 2022-03-05 20:00:52 PST 
Comment on attachment 453923 [details]
[fast-cq] proposed patch.

r=me
Comment 3 Mark Lam 2022-03-05 22:56:27 PST 
The 2 failing tests on the Win EWS are:
- fast/dom/connected-subframe-counter-overflow.html
- fast/frames/exponential-frames.html

According to: https://results.webkit.org/?suite=layout-tests&test=fast%2Fdom%2Fconnected-subframe-counter-overflow.html and https://results.webkit.org/?suite=layout-tests&test=fast%2Fframes%2Fexponential-frames.htm, the first is a flaky on Win10, and the second crashes all the time in recent builds.

Also, this patch only populates a HashMap that is only used on Debug build.  The Win EWS is running with a Release build.

This patch only takes effect on ARM64E CPUs.  The Win EWS runs on x86.

Hence, these failures cannot be due to this patch.
Comment 4 Mark Lam 2022-03-05 22:57:23 PST 
Comment on attachment 453923 [details]
[fast-cq] proposed patch.

Thanks for the review.  Landing now.
Comment 5 EWS 2022-03-05 23:00:09 PST 
Committed r290873 (248104@main): <https://commits.webkit.org/248104@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 453923 [details].