Bug 237349 - AX: Handle null FileList in RenderFileUploadControl::fileTextValue()
Summary: AX: Handle null FileList in RenderFileUploadControl::fileTextValue()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tyler Wilcock
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-03-01 17:13 PST by Tyler Wilcock
Modified: 2022-03-02 10:55 PST (History)
11 users (show)

See Also:

Attachments
Patch (2.04 KB, patch)
2022-03-01 17:47 PST, Tyler Wilcock 		no flags Details | Formatted Diff | Diff
Patch (2.04 KB, patch)
2022-03-01 18:18 PST, Tyler Wilcock 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tyler Wilcock 2022-03-01 17:13:00 PST 
In rare circumstances, it's possible for the FileList associated with RenderFileUploadControl::inputElement (HTMLInputElement::files()) to be null. We should avoid crashing in these scenarios.
Comment 1 Radar WebKit Bug Importer 2022-03-01 17:13:12 PST 
<rdar://problem/89651456>
Comment 2 Tyler Wilcock 2022-03-01 17:47:57 PST 
Created attachment 453555 [details]
Patch
Comment 3 chris fleizach 2022-03-01 17:56:56 PST 
Comment on attachment 453555 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453555&action=review

> Source/WebCore/rendering/RenderFileUploadControl.cpp:261
> +        return String();

return { };
Comment 4 Tyler Wilcock 2022-03-01 18:18:19 PST 
Created attachment 453559 [details]
Patch
Comment 5 Tyler Wilcock 2022-03-01 18:19:20 PST 
> > Source/WebCore/rendering/RenderFileUploadControl.cpp:261
> > +        return String();
> 
> return { };
Fixed.
Comment 6 EWS 2022-03-02 10:55:13 PST 
Committed r290738 (247984@main): <https://commits.webkit.org/247984@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 453559 [details].