Bug 237348 - [ iOS ] pointerevents/mouse/* 10 pointer event tests are constant timeouts or failures on iOS.
Summary: [ iOS ] pointerevents/mouse/* 10 pointer event tests are constant timeouts or...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-03-01 16:25 PST by Dawn Morningstar
Modified: 2022-03-02 07:35 PST (History)
5 users (show)

See Also:


Attachments
expectations (1.50 KB, patch)
2022-03-01 18:00 PST, Dawn Morningstar
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dawn Morningstar 2022-03-01 16:25:27 PST
pointerevents/mouse/pointer-event-basic-properties.html is a constant timeout on iOS queues ever since r287196 when it was unskipped. Current expectation is failing.

HISTORY:
https://results.webkit.org/?suite=layout-tests&test=pointerevents%2Fmouse%2Fpointer-event-basic-properties.html

DIFF-URL:
https://build.webkit.org/results/Apple-iPadOS-15-Simulator-Debug-WK2-Tests/r287196%20(555)/pointerevents/mouse/pointer-event-basic-properties-diff.txt

DIFF TEXT:
--- /Volumes/Data/worker/ipados-simulator-15-debug-tests-wk2/build/layout-test-results/pointerevents/mouse/pointer-event-basic-properties-expected.txt
+++ /Volumes/Data/worker/ipados-simulator-15-debug-tests-wk2/build/layout-test-results/pointerevents/mouse/pointer-event-basic-properties-actual.txt
@@ -1,3 +1,3 @@
+FAIL: Timed out waiting for notifyDone to be called
 
-PASS Testing the basic properties of a pointer event triggered by a mouse.
Comment 1 Radar WebKit Bug Importer 2022-03-01 16:29:02 PST
<rdar://problem/89648799>
Comment 2 Dawn Morningstar 2022-03-01 16:31:50 PST
Currently in r287196 all mouse functions are marked as failure on iOS with: pointerevents/mouse [ Failure ]

However not all tests are designed to Fail when mouse is not detected. I believe the solution to this bug would be to update the expectation on iOS to: 

pointerevents/mouse [ Failure Timeout ]

To account for the timeouts.
Comment 3 Alexey Proskuryakov 2022-03-01 17:14:17 PST
We don't want tests that consistently time out to run, because they are costly in terms of overall test run time.

pointerevents tests are not expected to run on iOS, we should just skip (and generally, undo the effects of r287196 on iOS).
Comment 4 Dawn Morningstar 2022-03-01 17:34:13 PST
(In reply to Alexey Proskuryakov from comment #3)
> We don't want tests that consistently time out to run, because they are
> costly in terms of overall test run time.
> 
> pointerevents tests are not expected to run on iOS, we should just skip (and
> generally, undo the effects of r287196 on iOS).

Thanks! I proposed the [ Timeout Failure ] because I assumed there MUST have been a reason for it to have been changed to a Failure expectation on iOS instead of a skip. But I agree, it would be better to skip. 

Fixing this bug by re-skipping on iOS.
Comment 5 Dawn Morningstar 2022-03-01 17:41:11 PST
Also of note this affects all pointerevents/mouse tests on iOS:
pointerevents/mouse/compatibility-mouse-events-prevention-mouse-pressed.html 
pointerevents/mouse/compatibility-mouse-events-prevention-mouse-released.html 
pointerevents/mouse/enter-leave-order.html
pointerevents/mouse/over-enter-out-leave.html
pointerevents/mouse/pointer-button-and-buttons.html 
pointerevents/mouse/pointer-capture-element-removal.html
pointerevents/mouse/pointer-capture.html
pointerevents/mouse/pointer-event-basic-properties.html
pointerevents/mouse/pointer-events-before-mouse-events.html
pointerevents/mouse/pointerdown-prevent-default.html

HISTORY:
https://results.webkit.org/?suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&suite=layout-tests&test=pointerevents%2Fmouse%2Fcompatibility-mouse-events-prevention-mouse-pressed.html&test=pointerevents%2Fmouse%2Fcompatibility-mouse-events-prevention-mouse-released.html&test=pointerevents%2Fmouse%2Fenter-leave-order.html&test=pointerevents%2Fmouse%2Fover-enter-out-leave.html&test=pointerevents%2Fmouse%2Fpointer-button-and-buttons.html&test=pointerevents%2Fmouse%2Fpointer-capture-element-removal.html&test=pointerevents%2Fmouse%2Fpointer-capture.html&test=pointerevents%2Fmouse%2Fpointer-event-basic-properties.html&test=pointerevents%2Fmouse%2Fpointer-events-before-mouse-events.html&test=pointerevents%2Fmouse%2Fpointerdown-prevent-default.html&platform=ios
Comment 6 Dawn Morningstar 2022-03-01 18:00:43 PST
Created attachment 453558 [details]
expectations
Comment 7 Robert Jenner 2022-03-01 18:11:18 PST
Comment on attachment 453558 [details]
expectations

Clearing flags on attachment: 453558

Committed r290716 (247963@trunk): <https://commits.webkit.org/247963@trunk>