Bug 237318 - Remove RemoteVideoSample support from ImageTransferSessionVT
Summary: Remove RemoteVideoSample support from ImageTransferSessionVT
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-03-01 04:14 PST by youenn fablet
Modified: 2022-03-01 23:10 PST (History)
10 users (show)

See Also:

Attachments
Patch (13.80 KB, patch)
2022-03-01 04:17 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch (13.76 KB, patch)
2022-03-01 04:22 PST, youenn fablet 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (13.19 KB, patch)
2022-03-01 05:00 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2022-03-01 04:14:01 PST 
Remove RemoteVideoSample support from ImageTransferSessionVT
Comment 1 youenn fablet 2022-03-01 04:17:33 PST 
Created attachment 453489 [details]
Patch
Comment 2 youenn fablet 2022-03-01 04:22:02 PST 
Created attachment 453490 [details]
Patch
Comment 3 youenn fablet 2022-03-01 05:00:29 PST 
Created attachment 453491 [details]
Patch
Comment 4 Eric Carlson 2022-03-01 09:16:11 PST 
Comment on attachment 453491 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453491&action=review

> Source/WebKit/WebProcess/cocoa/RemoteCaptureSampleManager.cpp:269
> +    auto videoFrame = MediaSampleAVFObjC::createImageSample(WTFMove(pixelBuffer), remoteSample.rotation(), remoteSample.mirrored(), remoteSample.time());

As a followup, I think `MediaSampleAVFObjC::createImageSample` is a slightly confusing name. Maybe something like `MediaSampleAVFObjC::createFromPixelBuffer` would be clearer?
Comment 5 EWS 2022-03-01 23:09:31 PST 
Committed r290721 (247968@main): <https://commits.webkit.org/247968@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 453491 [details].
Comment 6 Radar WebKit Bug Importer 2022-03-01 23:10:18 PST 
<rdar://problem/89667765>