Bug 237300 - Move StorageBucket function definitions outside the class definition
Summary: Move StorageBucket function definitions outside the class definition
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sihui Liu
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-02-28 18:31 PST by Sihui Liu
Modified: 2022-03-01 13:00 PST (History)
3 users (show)

See Also:

Attachments
Patch (29.77 KB, patch)
2022-02-28 19:51 PST, Sihui Liu 		no flags Details | Formatted Diff | Diff
Patch for landing (29.83 KB, patch)
2022-03-01 11:44 PST, Sihui Liu 		no flags Details | Formatted Diff | Diff
Patch for landing (29.81 KB, patch)
2022-03-01 11:58 PST, Sihui Liu 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sihui Liu 2022-02-28 18:31:27 PST 
...
Comment 1 Sihui Liu 2022-02-28 19:51:20 PST 
Created attachment 453466 [details]
Patch
Comment 2 Chris Dumez 2022-03-01 07:59:09 PST 
Comment on attachment 453466 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453466&action=review

r=me

> Source/WebKit/NetworkProcess/storage/OriginStorageManager.cpp:115
> +    return ""_s;

emptyString()

> Source/WebKit/NetworkProcess/storage/OriginStorageManager.cpp:166
> +    return m_localStorageManager.get();

This is a one liner, I think we should keep it inline within the class definition.

> Source/WebKit/NetworkProcess/storage/OriginStorageManager.cpp:179
> +    return m_sessionStorageManager.get();

ditto.

> Source/WebKit/NetworkProcess/storage/OriginStorageManager.cpp:192
> +    return m_idbStorageManager.get();

ditto.
Comment 3 Sihui Liu 2022-03-01 11:44:41 PST 
Created attachment 453515 [details]
Patch for landing
Comment 4 Sihui Liu 2022-03-01 11:58:44 PST 
Created attachment 453516 [details]
Patch for landing
Comment 5 EWS 2022-03-01 12:59:07 PST 
Committed r290669 (?): <https://commits.webkit.org/r290669>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 453516 [details].
Comment 6 Radar WebKit Bug Importer 2022-03-01 13:00:29 PST 
<rdar://problem/89636878>