Bug 237198 - RemoteVideoFrameObjectHeap should process its IPC messages in a background thread
Summary: RemoteVideoFrameObjectHeap should process its IPC messages in a background th...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on: 237191
Blocks:
  Show dependency tree / graph
 
Reported: 2022-02-25 04:25 PST by youenn fablet
Modified: 2022-02-28 03:13 PST (History)
13 users (show)

See Also:

Attachments
Patch (23.09 KB, patch)
2022-02-25 04:40 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (23.09 KB, patch)
2022-02-27 09:02 PST, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (23.96 KB, patch)
2022-02-27 23:13 PST, youenn fablet 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2022-02-25 04:25:46 PST 
RemoteVideoFrameObjectHeap should process its IPC messages in a background thread
Comment 1 youenn fablet 2022-02-25 04:40:42 PST 
Created attachment 453196 [details]
Patch
Comment 2 Darin Adler 2022-02-25 14:18:05 PST 
Comment on attachment 453196 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=453196&action=review

> Source/WebKit/GPUProcess/media/RemoteVideoFrameObjectHeap.cpp:47
> +    static auto& queue = WorkQueue::create("org.webkit.RemoteVideoFrameObjectHeap", WorkQueue::QOS::UserInteractive).leakRef();
> +    return queue;

In newer code we’ve been using NeverDestroyed rather than leakRef for cases like this. More like this:

    static NeverDestroyed queue = WorkQueue::create("org.webkit.RemoteVideoFrameObjectHeap", WorkQueue::QOS::UserInteractive;
    return queue;

Should be the same generated code.
Comment 3 youenn fablet 2022-02-27 09:02:10 PST 
Created attachment 453343 [details]
Patch for landing
Comment 4 youenn fablet 2022-02-27 23:13:34 PST 
Created attachment 453369 [details]
Patch for landing
Comment 5 EWS 2022-02-28 02:19:44 PST 
Committed r290591 (247869@main): <https://commits.webkit.org/247869@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 453369 [details].
Comment 6 Radar WebKit Bug Importer 2022-02-28 02:20:21 PST 
<rdar://problem/89548682>