WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
ASSIGNED
237056
git-webkit pr tried to create another commit from local changes on current branch
https://bugs.webkit.org/show_bug.cgi?id=237056
Summary
git-webkit pr tried to create another commit from local changes on current br...
Aakash Jain
Reported
2022-02-22 13:35:55 PST
I was on a branch, made a commit to it. I also had some local changes in other files. When I run git-webkit pr command, it automatically tried to create another commit from local changes. This might be unexpected for users, especially when they explicitly committed what they wanted to commit/push. Coupled with the fact that git-webkit pr doesn't show any preview before creating the PR, this might not be a good idea. git-webkit pr shouldn't try to automatically commit local changes when user is on a branch and there is already a commit by the user on that branch. Either errroring out or asking the user if he/she wants to create a commit from local changes is better.
Attachments
Add attachment
proposed patch, testcase, etc.
Jonathan Bedard
Comment 1
2022-02-22 13:53:44 PST
This is deliberate behavior, and aligns with what `webkit-patch` does. No particularly hard to change, but we need a larger discussion because my understand is that folks migrating from SVN largely find this behavior desirable.
Radar WebKit Bug Importer
Comment 2
2022-03-01 13:36:20 PST
<
rdar://problem/89638850
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug