Bug 236828 - [custom-effect] Animations associated with a custom effect should appear in document.getAnimations() result
Summary: [custom-effect] Animations associated with a custom effect should appear in d...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-02-18 00:17 PST by Antoine Quint
Modified: 2022-02-18 07:37 PST (History)
7 users (show)

See Also:

Attachments
Patch (4.52 KB, patch)
2022-02-18 00:18 PST, Antoine Quint 		dino: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2022-02-18 00:17:47 PST 
[custom-effect] Animations associated with a custom effect should appear in document.getAnimations() result
Comment 1 Antoine Quint 2022-02-18 00:18:15 PST 
Created attachment 452492 [details]
Patch
Comment 2 Dean Jackson 2022-02-18 04:20:19 PST 
Comment on attachment 452492 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452492&action=review

> LayoutTests/ChangeLog:9
> +        * webanimations/custom-effect/custom-effect-get-animations-expected.txt: Added.
> +        * webanimations/custom-effect/custom-effect-get-animations.html: Added.

Shouldn't this be in a WPT directory so we can contribute it back? What will track that effort?
Comment 3 Antoine Quint 2022-02-18 04:22:57 PST 
(In reply to Dean Jackson from comment #2)
> Comment on attachment 452492 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=452492&action=review
> 
> > LayoutTests/ChangeLog:9
> > +        * webanimations/custom-effect/custom-effect-get-animations-expected.txt: Added.
> > +        * webanimations/custom-effect/custom-effect-get-animations.html: Added.
> 
> Shouldn't this be in a WPT directory so we can contribute it back? What will
> track that effort?

I'm writing all of those custom-effect tests with testharness so we may contribute them back, but I don't think we should upstream them until there are approved pull requests for the changes suggested.
Comment 4 Antoine Quint 2022-02-18 07:36:13 PST 
Committed r290122 (?): <https://commits.webkit.org/r290122>
Comment 5 Radar WebKit Bug Importer 2022-02-18 07:37:18 PST 
<rdar://problem/89144597>