Created attachment 452312 [details]
Patch

Comment on attachment 452312 [details]
Patch

I'm not supposed to land this quite yet.

Comment on attachment 452312 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452312&action=review

> Source/WTF/wtf/PlatformHave.h:1147
>  #if PLATFORM(COCOA)

This needs to be #if PLATFORM(COCOA) && !CPU(APPLE_ARMV7K)

Comment on attachment 452312 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452312&action=review

> Source/WebCore/Configurations/WebCore.xcconfig:89
> +WK_WEBGPU_LDFLAGS = -weak_framework WebGPU;

Can we actually do this? I didn't think so, because of shared cache.

Comment on attachment 452312 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452312&action=review

>> Source/WebCore/Configurations/WebCore.xcconfig:89
>> +WK_WEBGPU_LDFLAGS = -weak_framework WebGPU;
> 
> Can we actually do this? I didn't think so, because of shared cache.

Why not? It's what ANGLE does directly above.

Discussed directly, seems fine, but it was worth getting on the same page as to why.

Comment on attachment 452312 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452312&action=review

>>> Source/WebCore/Configurations/WebCore.xcconfig:89
>>> +WK_WEBGPU_LDFLAGS = -weak_framework WebGPU;
>> 
>> Can we actually do this? I didn't think so, because of shared cache.
> 
> Why not? It's what ANGLE does directly above.

Instead of doing weak linking, we can use regular linking, but only do it on the relevant operating systems.

Except that we apparently do need weak linking on macOS.

<rdar://problem/89398482>

Comment on attachment 452312 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=452312&action=review

>> Source/WTF/wtf/PlatformHave.h:1147
>>  #if PLATFORM(COCOA)
> 
> This needs to be #if PLATFORM(COCOA) && !CPU(APPLE_ARMV7K)

Nevermind. WebGPU doesn't require a 64-bit device.

>>>> Source/WebCore/Configurations/WebCore.xcconfig:89
>>>> +WK_WEBGPU_LDFLAGS = -weak_framework WebGPU;
>>> 
>>> Can we actually do this? I didn't think so, because of shared cache.
>> 
>> Why not? It's what ANGLE does directly above.
> 
> Instead of doing weak linking, we can use regular linking, but only do it on the relevant operating systems.

Weak linking is required because of the base system.

Created attachment 456087 [details]
Patch for committing

Committed r292138 (249045@main): <https://commits.webkit.org/249045@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 456087 [details].