Bug 236705 - [EWS][GTK] Send only one e-mail with all the list of flakies
Summary: [EWS][GTK] Send only one e-mail with all the list of flakies
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Carlos Alberto Lopez Perez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2022-02-16 07:54 PST by Carlos Alberto Lopez Perez
Modified: 2022-02-16 12:54 PST (History)
11 users (show)

See Also:

Attachments
Patch (6.89 KB, patch)
2022-02-16 08:01 PST, Carlos Alberto Lopez Perez 		no flags Details | Formatted Diff | Diff
Patch (38.93 KB, patch)
2022-02-16 10:53 PST, Carlos Alberto Lopez Perez 		no flags Details | Formatted Diff | Diff
Patch (43.50 KB, patch)
2022-02-16 12:00 PST, Carlos Alberto Lopez Perez 		no flags Details | Formatted Diff | Diff
Patch (40.99 KB, patch)
2022-02-16 12:43 PST, Carlos Alberto Lopez Perez 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Alberto Lopez Perez 2022-02-16 07:54:02 PST 
The current EWS for GTK layout tests is sending one e-mail per flaky detected (one per test).
This seems is too much and we are spamming ourselves.

Change this to only send one e-mail per run with the list of all flakies detected in the body of the e-mail
Comment 1 Carlos Alberto Lopez Perez 2022-02-16 08:01:03 PST 
Created attachment 452198 [details]
Patch
Comment 2 Aakash Jain 2022-02-16 10:00:19 PST 
Ryan what do you think about this?
Comment 3 Carlos Alberto Lopez Perez 2022-02-16 10:48:04 PST 
I'm going to upload a new version that adds unit tests for this, to check that the mail messages are created with the expected content
Comment 4 Carlos Alberto Lopez Perez 2022-02-16 10:49:29 PST 
(In reply to Aakash Jain from comment #2)
> Ryan what do you think about this?

Note that this will only affect the GTK layout tests on the EWS.

The other EWS for layout test (Apple ones) still keep sending one e-mail per flaky test
Comment 5 Carlos Alberto Lopez Perez 2022-02-16 10:53:17 PST 
Created attachment 452213 [details]
Patch
Comment 6 Ryan Haddad 2022-02-16 11:34:18 PST 
(In reply to Carlos Alberto Lopez Perez from comment #4)
> (In reply to Aakash Jain from comment #2)
> > Ryan what do you think about this?
> 
> Note that this will only affect the GTK layout tests on the EWS.
> 
> The other EWS for layout test (Apple ones) still keep sending one e-mail per
> flaky test
Got it, thank you for clarifying!
Comment 7 Carlos Alberto Lopez Perez 2022-02-16 12:00:42 PST 
Created attachment 452226 [details]
Patch

trying EWS
Comment 8 Carlos Alberto Lopez Perez 2022-02-16 12:43:31 PST 
Created attachment 452230 [details]
Patch

trying EWS again, includes also the fixes commented at https://bugs.webkit.org/show_bug.cgi?id=236654#c4
Comment 9 Carlos Alberto Lopez Perez 2022-02-16 12:53:09 PST 
Committed r289947 (247349@trunk): <https://commits.webkit.org/247349@trunk>
Comment 10 Radar WebKit Bug Importer 2022-02-16 12:54:19 PST 
<rdar://problem/89043231>