We currently store columns in logical order (column 0 is the rightmost physical column), but we offset these positions using the physical left border, padding and content distribution offset. This makes for some tricky conversions to get into the final coordinates to set on the RenderElement. I think we can store purely logical coordinates, and subtract that from the width to get the final coordinates.
Created attachment 452156 [details] Patch
Comment on attachment 452156 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452156&action=review This is a great cleanup, if all tests keep passing (EWS are red now as the patch doesn't apply), it'd be nice to get it landed. > Source/WebCore/rendering/RenderGrid.cpp:1575 > +LayoutUnit RenderGrid::resolveAutoStartGridPosition(GridTrackSizingDirection) const This method doesn't use the param, please remove it. Also this method just returns zero, do we need a method for this? > Source/WebCore/rendering/RenderGrid.cpp:1584 > return clientLogicalWidth(); This method is now very simple, maybe we don't need it like resolveAutoStartGridPosition(). > Source/WebCore/rendering/RenderGrid.cpp:1651 > + Nit: Extra line not needed.
Created attachment 452219 [details] Patch
Created attachment 452220 [details] Patch for EWS including bug 236626
(In reply to Manuel Rego Casasnovas from comment #2) > Comment on attachment 452156 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=452156&action=review > > This is a great cleanup, if all tests keep passing (EWS are red now as the > patch doesn't apply), it'd be nice to get it landed. Hopefully the 'Patch for EWS' is green now, it depends on bug 236626 (which is a bit ugly, but adds a test, and inspired this cleanup).
This patch modifies the imported WPT tests. Please ensure that any changes on the tests (not coming from a WPT import) are exported to WPT. Please see https://trac.webkit.org/wiki/WPTExportProcess
Comment on attachment 452219 [details] Patch rs=me but it seems iOS isn't quite happy applying the landing patch.
Created attachment 452765 [details] Patch
Comment on attachment 452765 [details] Patch Assuming the bots get another crack at this after the WebGPU breakage is cleared...
<rdar://problem/89342456>
mattwoodrow@apple.com does not have committer permissions according to https://raw.githubusercontent.com/WebKit/WebKit/main/metadata/contributors.json. Rejecting attachment 452765 [details] from commit queue.
Committed r290491 (247781@main): <https://commits.webkit.org/247781@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 452765 [details].